All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Philip Rakity <prakity@marvell.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Albert Herranz <albert_herranz@yahoo.es>
Subject: Re: [BUG] CMD52 sent as first command not CMD0
Date: Sun, 6 Feb 2011 01:15:14 +0000	[thread overview]
Message-ID: <20110206011514.GA15322@void.printf.net> (raw)
In-Reply-To: <BC6C6C10-631A-4482-BA1B-C6F0057BC54A@marvell.com>

On Sat, Feb 05, 2011 at 04:52:12PM -0800, Philip Rakity wrote:
> nothing negative but reset is meant to reinit the card.  This is the power up sequence for the 1st time a card is detected.
> There is no reason to do this if no card has yet enumerated.  If a sdio card was there I completely agree with the mod since we need to reset 
> the card. 
> 
> CMD0 should be the 1st command on an initial power up sequence.  Does my code suggestion work for you ?

Okay -- yes, looks fine.  Let's add a comment beforehand; something like:

/* If reinitalizing, we must send CMD52 before CMD0 for SDIO. */

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  parent reply	other threads:[~2011-02-06  1:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-04 22:53 [BUG] CMD52 sent as first command not CMD0 Philip Rakity
2011-02-04 23:19 ` Philip Rakity
2011-02-06  0:38 ` Chris Ball
2011-02-06  0:52   ` Philip Rakity
2011-02-06  1:11     ` Philip Rakity
2011-02-06  1:15     ` Chris Ball [this message]
2011-02-06  1:35       ` Philip Rakity
2011-02-06  1:50         ` Chris Ball
2011-02-06 16:02           ` David Vrabel
2011-02-06 11:13         ` Albert Herranz
2011-02-06 20:50           ` Philip Rakity
2011-02-07  0:55             ` Nicolas Pitre
2011-02-06 16:09     ` Tardy, Pierre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110206011514.GA15322@void.printf.net \
    --to=cjb@laptop.org \
    --cc=albert_herranz@yahoo.es \
    --cc=linux-mmc@vger.kernel.org \
    --cc=prakity@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.