From: Andres Salomon <dilinger@queued.net>
To: Greg KH <gregkh@suse.de>
Cc: Marek Belisko <marek.belisko@open-nandra.com>,
cjb@laptop.org, jon.nettleton@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] olpc_dcon: revert strtoul change
Date: Sun, 6 Feb 2011 14:38:16 -0800 [thread overview]
Message-ID: <20110206143816.0355ddc5@queued.net> (raw)
In-Reply-To: <20110204234443.GB4147@suse.de>
On Fri, 4 Feb 2011 15:44:43 -0800
Greg KH <gregkh@suse.de> wrote:
> On Fri, Feb 04, 2011 at 03:23:41PM -0800, Andres Salomon wrote:
> > No opinions on this patch (there are some things I'd do differently,
> > but overall it looks fine). I'd just like to ensure that if it's
> > merged, it gets into Linus's tree quickly so that the DCON reworking
> > that I'm planning to do doesn't get sidetracked by conflicts.
>
> It is planned to go to Linus for .39 and is now in the linux-next tree
> as of tomorrow.
>
> thanks,
>
> greg k-h
Ugh, this actually causes build warnings and causes XOs to fail to
boot. Seems like the strict_strtoul change broke things; this patch
backs that out. We can fix it properly later.
Greg, can you please apply?
From: Andres Salomon <dilinger@queued.net>
The s/simple_strtoul/strict_strtoul/ from commit e107e6eb added a build
warning, as well as an oops. This reverts that change.
Signed-off-by: Andres Salomon <dilinger@queued.net>
---
drivers/staging/olpc_dcon/olpc_dcon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
index b19cd34..d6ad5d7 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon.c
@@ -525,7 +525,7 @@ static int _strtoul(const char *buf, int len, unsigned int *val)
{
char *endp;
- unsigned int output = strict_strtoul(buf, &endp, 0);
+ unsigned int output = simple_strtoul(buf, &endp, 0);
int size = endp - buf;
if (*endp && isspace(*endp))
--
1.7.2.3
next prev parent reply other threads:[~2011-02-06 22:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 15:22 [PATCH] staging: olpc_dcon: checkpatch.pl fixes for olpc_dcon.c file Marek Belisko
2011-02-04 23:23 ` Andres Salomon
2011-02-04 23:44 ` Greg KH
2011-02-06 22:38 ` Andres Salomon [this message]
2011-02-06 23:05 ` [PATCH] olpc_dcon: revert strtoul change Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110206143816.0355ddc5@queued.net \
--to=dilinger@queued.net \
--cc=cjb@laptop.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jon.nettleton@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@open-nandra.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.