From: Dan Carpenter <error27@gmail.com>
To: Andres Salomon <dilinger@queued.net>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org,
jon.nettleton@gmail.com, cjb@laptop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] olpc_dcon: move more variables into dcon_priv
Date: Mon, 7 Feb 2011 09:30:47 +0300 [thread overview]
Message-ID: <20110207063047.GC4384@bicker> (raw)
In-Reply-To: <20110206152846.68f14482@queued.net>
On Sun, Feb 06, 2011 at 03:28:46PM -0800, Andres Salomon wrote:
> bool mono:1;
> + bool asleep:1;
^^
Not needed.
> - return sprintf(buf, "%d\n", dcon_sleep_val);
> + struct dcon_priv *dcon = dev_get_drvdata(dev);
> + return sprintf(buf, "%d\n", dcon->asleep ? 1 : 0);
^^^^^^^
Also not needed.
These are fussy things. Feel free to fix them in a later patch series.
regards,
dan carpenter
prev parent reply other threads:[~2011-02-07 6:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 23:28 [PATCH 3/4] olpc_dcon: move more variables into dcon_priv Andres Salomon
2011-02-07 6:30 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207063047.GC4384@bicker \
--to=error27@gmail.com \
--cc=cjb@laptop.org \
--cc=devel@driverdev.osuosl.org \
--cc=dilinger@queued.net \
--cc=gregkh@suse.de \
--cc=jon.nettleton@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.