From: Ted Ts'o <tytso@mit.edu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: i@coly.li, linux-ext4@vger.kernel.org,
Alex Tomas <alex@clusterfs.com>, Theodore Tso <tytso@google.com>
Subject: Re: [PATCH 0/5] mballoc: trivial code cleanup
Date: Mon, 7 Feb 2011 12:41:25 -0500 [thread overview]
Message-ID: <20110207174125.GB3457@thunk.org> (raw)
In-Reply-To: <AANLkTimT3i1oOSh02oTtvN_OmHcYwhNOABLV4cT7VV5p@mail.gmail.com>
On Sun, Feb 06, 2011 at 10:43:58AM +0200, Amir Goldstein wrote:
> When looking at alloc_sem, I realized that it is only needed to avoid
> race with adjacent group buddy initialization.
Actually, alloc_sem is used to protect all of the block group specific
data structures; the buddy bitmap counters, adjusting the buddy bitmap
itself, the largest free order in a block group, etc. So even in the
case where block_size == page_size, alloc_sem is still needed!
- Ted
next prev parent reply other threads:[~2011-02-07 17:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 4:53 [PATCH 0/5] mballoc: trivial code cleanup Coly Li
2011-02-06 8:43 ` Amir Goldstein
2011-02-07 17:41 ` Ted Ts'o [this message]
2011-02-07 20:59 ` Amir Goldstein
2011-02-07 22:24 ` Ted Ts'o
2011-02-08 8:54 ` Amir Goldstein
2011-02-09 9:09 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207174125.GB3457@thunk.org \
--to=tytso@mit.edu \
--cc=alex@clusterfs.com \
--cc=amir73il@gmail.com \
--cc=i@coly.li \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.