From: David Miller <davem@davemloft.net>
To: toshiharu-linux@dsn.okisemi.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
qi.wang@intel.com, yong.y.wang@intel.com,
andrew.chih.howe.khor@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com, tomoya-linux@dsn.okisemi.com
Subject: Re: [PATCH] pch_gbe: Fix the issue that the receiving data is not normal.
Date: Tue, 08 Feb 2011 16:35:22 -0800 (PST) [thread overview]
Message-ID: <20110208.163522.232741523.davem@davemloft.net> (raw)
In-Reply-To: <4D50FDAA.1060506@dsn.okisemi.com>
From: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
Date: Tue, 08 Feb 2011 17:24:10 +0900
> Hi Devid
>
> I resubmit this patch modified.
> Please check them.
Your memcpy+memcpy sequences are equivalent to memmove(), please
use that instead.
I have to say this function is insanely complicated. There seems
to be 16 different ways RX packets are processed. I can't believe
that is needs to be like this.
next prev parent reply other threads:[~2011-02-09 0:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 8:24 [PATCH] pch_gbe: Fix the issue that the receiving data is not normal Toshiharu Okada
2011-02-09 0:35 ` David Miller [this message]
2011-02-09 4:58 ` Toshiharu Okada
-- strict thread matches above, loose matches on Subject: below --
2011-01-24 4:43 Toshiharu Okada
2011-01-25 21:32 ` David Miller
2011-01-27 8:45 ` Toshiharu Okada
2011-01-27 8:45 ` Toshiharu Okada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208.163522.232741523.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew.chih.howe.khor@intel.com \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=toshiharu-linux@dsn.okisemi.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.