All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Marek Belisko <marek.belisko@open-nandra.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org,
	jon.nettleton@gmail.com, linux-kernel@vger.kernel.org,
	dilinger@queued.net, cjb@laptop.org
Subject: Re: [PATCH RFC] staging: olpc_dcon: Remove _strtoul() function.
Date: Tue, 8 Feb 2011 14:23:54 +0300	[thread overview]
Message-ID: <20110208112354.GN4384@bicker> (raw)
In-Reply-To: <1297163160-23429-1-git-send-email-marek.belisko@open-nandra.com>

On Tue, Feb 08, 2011 at 12:06:00PM +0100, Marek Belisko wrote:
> olpc_dcon driver use self invented _strtoul  function
> which make similar check like strict_strtoul just extend
> for space checking at last string place. Normally access
> to sys file looks echo 1024 > /sys/... so space could be considered
> as error character and we could simplify code using just strict_strtoul
> function instead self invented.
> 

Could you do it on top of the patches that Andres Salomon sent?

http://driverdev.linuxdriverproject.org/pipermail/devel/2011-February/thread.html

# [PATCH 1/4] olpc_dcon: get rid of global i2c_client, create a dcon_priv struct   Andres Salomon
# [PATCH 2/4] olpc_dcon: change sysfs 'output' toggle to be clearer...   Andres Salomon
# [PATCH 3/4] olpc_dcon: move more variables into dcon_priv   Andres Salomon
# [PATCH 4/4] olpc_dcon: actually return the value of i2c_add_driver   Andres Salomon 

regards,
dan carpenter



  reply	other threads:[~2011-02-08 11:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08 11:06 [PATCH RFC] staging: olpc_dcon: Remove _strtoul() function Marek Belisko
2011-02-08 11:23 ` Dan Carpenter [this message]
2011-02-08 12:02   ` Belisko Marek
2011-02-08 17:40   ` Andres Salomon
2011-02-09 20:04     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110208112354.GN4384@bicker \
    --to=error27@gmail.com \
    --cc=cjb@laptop.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=dilinger@queued.net \
    --cc=gregkh@suse.de \
    --cc=jon.nettleton@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.belisko@open-nandra.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.