Re: What's part of the ABI (breaking eeepc-wmi)

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Tue, Feb 08, 2011 at 03:17:35PM +0000, Corentin Chary wrote:
> On Tue, Feb 8, 2011 at 2:53 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> > On Tue, Feb 08, 2011 at 08:51:27AM +0000, Corentin Chary wrote:
> >
> >> A first solution is to rename eeepc-wmi asus-wmi, and create an alias
> >> to make eeepc-wmi work. Then this driver would handle asus-wmi and
> >> eeepc-wmi platform drivers (it could also be splitted in 3
> >> files/modules, common/notebook/eeepc).
> >> But then, is it important to keep these strings ?
> >> - hotplug string ("eeepc-wifi")
> >> - rfkill names ("eeepc-xxxxx")
> >> - input strings (.phys and .name)
> >
> > I think that, realistically, these changes should be fine but may break
> > some user code. We don't have a good way of enforcing proper sysfs
> > usage.
> 
> Unfortunatly, it would break udev (well.. only the touchpad key, which
> probably never worked, does it really matters ?) ...
> 
> http://git.kernel.org/?p=linux/hotplug/udev.git;a=blobdiff;f=extras/keymap/95-keymap.rules;h=9059a8c41e4505f0d8088a90fc0c3a64fe8d5f2d;hp=053838d803d7142dd80fbca361ef65565c6189f2;hb=0d8b6be5f5238360d2d8e220d6da280f842c5358;hpb=e99cc72398d1d5057cc6d1e4c065799f8daaf29e
> 
> But your probably right for rfkill and hotplug slot name.
> 

As we can't be sure about individual user's set ups (they might very
well use their own rules and maps) we should try to keep the existign
setups intact, if at all possible.

Thanks.

-- 
Dmitry