All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Stezenbach <js@sig21.net>
To: Kalle Valo <kvalo@adurom.com>
Cc: Ivo van Doorn <ivdoorn@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [RFC] rt2x00: Add autowakeup timer for receiving beacons while in powersave mode
Date: Tue, 8 Feb 2011 21:09:05 +0100	[thread overview]
Message-ID: <20110208200905.GB32133@sig21.net> (raw)
In-Reply-To: <87r5bj7wyx.fsf@purkki.adurom.net>

On Tue, Feb 08, 2011 at 10:27:02AM +0200, Kalle Valo wrote:
> So I have my concerns if it really makes sense to implement this in
> mac80211. Extra complexity (and extra maintenance) for two sub-optimal
> (from power save point of view) hardware.

Agreed the timer thing is ugly and should stay in the driver,
provided it survives stress testing.

But the mc/bc check Ivo suggested as part of his RFC patch is already on
the mac80211 TODO list because of ath9k (ath_beacon_dtim_pending_cab()):
http://wireless.kernel.org/en/developers/todo-list#power_saving

I'm not sure if the mac80211 changes suggested by Ivo would work for
ath9k (and carl9170 which also has a similar check).  Maybe someone
could comment on that.


Johannes

      reply	other threads:[~2011-02-08 20:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-31 15:00 [RFC] rt2x00: Add autowakeup timer for receiving beacons while in powersave mode Ivo van Doorn
2011-01-31 15:22 ` Johannes Berg
2011-01-31 15:38   ` Ivo Van Doorn
2011-01-31 15:54     ` [rt2x00-users] " Johannes Stezenbach
2011-01-31 18:17 ` Johannes Stezenbach
2011-01-31 19:00   ` Ivo Van Doorn
2011-01-31 21:05     ` Johannes Stezenbach
2011-02-02 17:42 ` Kalle Valo
2011-02-02 19:09   ` Ivo Van Doorn
2011-02-10  5:24     ` RA-Jay Hung
2011-02-14 10:14       ` Ivo Van Doorn
2011-02-14 10:25         ` Johannes Berg
2011-02-02 21:29   ` Johannes Stezenbach
2011-02-07 23:33     ` [rt2x00-users] " Aleksandar Milivojevic
2011-02-08  8:48       ` Kalle Valo
2011-02-08 19:11         ` Aleksandar Milivojevic
2011-02-09 12:17           ` Kalle Valo
2011-02-09 14:31           ` Johannes Stezenbach
2011-02-08  8:27     ` Kalle Valo
2011-02-08 20:09       ` Johannes Stezenbach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110208200905.GB32133@sig21.net \
    --to=js@sig21.net \
    --cc=ivdoorn@gmail.com \
    --cc=kvalo@adurom.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.