From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] dma: shdma: add checking the DMAOR_AE in sh_dmae_err
Date: Wed, 09 Feb 2011 07:19:39 +0000 [thread overview]
Message-ID: <20110209071939.GA16518@linux-sh.org> (raw)
In-Reply-To: <4D523980.2080309@renesas.com>
On Wed, Feb 09, 2011 at 03:51:44PM +0900, Yoshihiro Shimoda wrote:
> The irq numbers of tranfer end and address error are assigned same number
> on some CPU. So the sh_dmae_err() should check the AE flag in DMAOR.
>
Looks ok, but..
> static irqreturn_t sh_dmae_err(int irq, void *data)
> {
> - return IRQ_RETVAL(sh_dmae_reset(data));
> + struct sh_dmae_device *shdev = (struct sh_dmae_device *)data;
> +
Please do not ever cast void pointers, it's completely pointless and just
means someone else has to go and tidy up the patch manually.
next prev parent reply other threads:[~2011-02-09 7:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 6:51 [PATCH] dma: shdma: add checking the DMAOR_AE in sh_dmae_err Yoshihiro Shimoda
2011-02-09 7:19 ` Paul Mundt [this message]
2011-02-09 7:44 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110209071939.GA16518@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.