From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Koul, Vinod" <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org,
Harsha Priya <priya.harsha@intel.com>,
lrg@slimlogic.co.uk
Subject: Re: [PATCH 1/3] ASoC: sn95031: Add jack support in the codec
Date: Wed, 9 Feb 2011 12:11:39 +0000 [thread overview]
Message-ID: <20110209121139.GA24042@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1297242747-18632-2-git-send-email-vinod.koul@intel.com>
On Wed, Feb 09, 2011 at 02:42:25PM +0530, Koul, Vinod wrote:
> +void disable_jack_btn(struct snd_soc_codec *codec)
> +{
> + snd_soc_write(codec, SN95031_BTNCTRL2, 0x00);
> +}
> +EXPORT_SYMBOL_GPL(disable_jack_btn);
This needs to be namespaced. It's also surprising that the matching
enable function isn't exposed...
The code itself looks OK.
next prev parent reply other threads:[~2011-02-09 12:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 9:12 [PATCH 0/3] add support for jack detection in mid-x86 Koul, Vinod
2011-02-09 9:12 ` [PATCH 1/3] ASoC: sn95031: Add jack support in the codec Koul, Vinod
2011-02-09 12:11 ` Mark Brown [this message]
2011-02-09 13:06 ` Koul, Vinod
2011-02-09 13:07 ` Mark Brown
2011-02-09 9:12 ` [PATCH 2/3] ASoC: mfld_machine: Add support for jack detection Koul, Vinod
2011-02-09 13:55 ` Mark Brown
2011-02-09 14:38 ` Koul, Vinod
2011-02-09 14:39 ` Mark Brown
2011-02-09 14:53 ` Koul, Vinod
2011-02-09 9:12 ` [PATCH 3/3] ASoC: sn95031: Add support for reading mic bias Koul, Vinod
2011-02-09 15:06 ` Mark Brown
2011-02-09 15:09 ` Koul, Vinod
-- strict thread matches above, loose matches on Subject: below --
2011-02-09 16:14 [PATCH 0/3] add support for jack detection in mid-x86 Koul, Vinod
2011-02-09 16:14 ` [PATCH 1/3] ASoC: sn95031: Add jack support in the codec Koul, Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110209121139.GA24042@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=priya.harsha@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.