From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vms173013pub.verizon.net ([206.46.173.13]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1PnHxv-0003BR-FS for openembedded-devel@lists.openembedded.org; Wed, 09 Feb 2011 22:52:47 +0100 Received: from gandalf.denix.org ([unknown] [71.251.49.88]) by vms173013.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0LGD007M5B8O2IK2@vms173013.mailsrvcs.net> for openembedded-devel@lists.openembedded.org; Wed, 09 Feb 2011 14:51:00 -0600 (CST) Received: by gandalf.denix.org (Postfix, from userid 1000) id E637714AF6D; Wed, 09 Feb 2011 15:50:47 -0500 (EST) Date: Wed, 09 Feb 2011 15:50:47 -0500 From: Denys Dmytriyenko To: openembedded-devel@lists.openembedded.org Message-id: <20110209205047.GA32089@denix.org> References: <1297283819-15670-1-git-send-email-Chase.Maupin@ti.com> MIME-version: 1.0 In-reply-to: <1297283819-15670-1-git-send-email-Chase.Maupin@ti.com> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: Chase Maupin Subject: Re: [PATCH] cups: fix desktop file QA issues X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Feb 2011 21:52:47 -0000 Content-type: text/plain; charset=us-ascii Content-disposition: inline On Wed, Feb 09, 2011 at 02:36:59PM -0600, Chase Maupin wrote: > * This patch fixes the QA issues with version 1.2.12 of cups. > * The patch being applied was taken from > http://bugs.gentoo.org/show_bug.cgi?id=236706 > * Bump the PR > > Signed-off-by: Chase Maupin Acked-by: Denys Dmytriyenko > --- > .../0001-cups-desktop-fix-cups-desktop-file.patch | 48 ++++++++++++++++++++ > recipes/cups/cups_1.2.12.bb | 4 +- > 2 files changed, 51 insertions(+), 1 deletions(-) > create mode 100644 recipes/cups/cups-1.2.12/0001-cups-desktop-fix-cups-desktop-file.patch > > diff --git a/recipes/cups/cups-1.2.12/0001-cups-desktop-fix-cups-desktop-file.patch b/recipes/cups/cups-1.2.12/0001-cups-desktop-fix-cups-desktop-file.patch > new file mode 100644 > index 0000000..bb76d17 > --- /dev/null > +++ b/recipes/cups/cups-1.2.12/0001-cups-desktop-fix-cups-desktop-file.patch > @@ -0,0 +1,48 @@ > +From 85710dd8f749a447301e1522e6022b62e29d6f5d Mon Sep 17 00:00:00 2001 > +From: Chase Maupin > +Date: Wed, 9 Feb 2011 14:20:51 -0600 > +Subject: [PATCH] cups desktop: fix cups desktop file > + > +* Fix the cups.desktop file to address issues reported by the > + desktop-file-validate program. This resolves QA error > + issues generated by the insane class: > + ERROR: QA Issue with cups: cups.desktop: warning: value > + "Application;System;X-Red-Hat-Base;" for key "Categories" in group " > + Desktop Entry" contains a deprecated value "Application" > + ERROR: QA Issue with cups: cups.desktop: warning: key "Encoding" in group > + "Desktop Entry" is deprecated > + ERROR: QA Issue with cups: cups.desktop: warning: value "" for key > + "Path" in group "Desktop Entry" does not look like an absolute path > + ERROR: QA Issue with cups: cups.desktop: warning: key "TerminalOptions" > + in group "Desktop Entry" is deprecated > +* This patch was obtained from http://bugs.gentoo.org/show_bug.cgi?id=236706 > + and thank to Pacho Ramos for the fix > + > +Signed-off-by: Chase Maupin > +--- > + desktop/cups.desktop | 5 +---- > + 1 files changed, 1 insertions(+), 4 deletions(-) > + > +diff --git a/desktop/cups.desktop b/desktop/cups.desktop > +index dabfba3..28b98d9 100644 > +--- a/desktop/cups.desktop > ++++ b/desktop/cups.desktop > +@@ -1,14 +1,11 @@ > + [Desktop Entry] > +-Categories=Application;System;X-Red-Hat-Base; > +-Encoding=UTF-8 > ++Categories=System;X-Red-Hat-Base; > + Exec=htmlview http://localhost:631/ > + GenericName= > + Icon=cups > + MimeType= > +-Path= > + StartupNotify=false > + Terminal=false > +-TerminalOptions= > + Type=Application > + X-DCOP-ServiceType= > + X-KDE-SubstituteUID=false > +-- > +1.7.0.4 > + > diff --git a/recipes/cups/cups_1.2.12.bb b/recipes/cups/cups_1.2.12.bb > index 6df928a..167d353 100644 > --- a/recipes/cups/cups_1.2.12.bb > +++ b/recipes/cups/cups_1.2.12.bb > @@ -1,5 +1,7 @@ > require cups.inc > -PR = "${INC_PR}.2" > +PR = "${INC_PR}.3" > + > +SRC_URI += "file://0001-cups-desktop-fix-cups-desktop-file.patch" > > SRC_URI[md5sum] = "d410658468384b5ba5d04a808f6157fe" > SRC_URI[sha256sum] = "b4ff8e934da7db32d5654360ea9068faa0ed5a00fde02161ae53c2052510d00f" > -- > 1.7.0.4 > > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel