From: Vlad Dogaru <ddvlad@rosedu.org>
To: David Miller <davem@davemloft.net>
Cc: dfeng@redhat.com, netdev@vger.kernel.org, eric.dumazet@gmail.com,
therbert@google.com, ebiederm@xmission.com,
shemminger@vyatta.com
Subject: Re: [RFC PATCH net-next] net: rename group sysfs entry to netdev_group
Date: Thu, 10 Feb 2011 11:11:35 +0200 [thread overview]
Message-ID: <20110210091135.GA24889@cormyr> (raw)
In-Reply-To: <20110209.140323.39178091.davem@davemloft.net>
On Wed, Feb 09, 2011 at 02:03:23PM -0800, David Miller wrote:
> From: Xiaotian feng <dfeng@redhat.com>
> Date: Wed, 9 Feb 2011 18:52:49 +0800
>
> > From: Xiaotian Feng <dfeng@redhat.com>
> >
> > commit a512b92 adds sysfs entry for net device group, but
> > before this commit, tun also uses group sysfs, so after this
> > commit checkin, kernel warns like this:
> > sysfs: cannot create duplicate filename '/devices/virtual/net/vnet0/group'
> >
> > Since tun has used this for years, rename sysfs under tun might
> > break existing userspace, so rename group sysfs entry for net device
> > group is a better choice.
I was not aware of that, sorry for breaking things :)
prev parent reply other threads:[~2011-02-10 9:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 10:52 [RFC PATCH net-next] net: rename group sysfs entry to netdev_group Xiaotian feng
2011-02-09 22:03 ` David Miller
2011-02-09 22:05 ` David Miller
2011-02-10 2:54 ` Xiaotian Feng
2011-02-10 3:16 ` David Miller
2011-02-10 9:11 ` Vlad Dogaru [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110210091135.GA24889@cormyr \
--to=ddvlad@rosedu.org \
--cc=davem@davemloft.net \
--cc=dfeng@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.