All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Pedanekar, Hemant" <hemantp@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Hilman, Kevin" <khilman@ti.com>,
	"paul@pwsan.com" <paul@pwsan.com>
Subject: Re: [PATCH v5 2/4] TI816X: Update common OMAP machine specific sources
Date: Thu, 10 Feb 2011 09:02:02 -0800	[thread overview]
Message-ID: <20110210170202.GK20795@atomide.com> (raw)
In-Reply-To: <2A3DCF3DA181AD40BDE86A3150B27B6B036ACA3CB4@dbde02.ent.ti.com>

* Pedanekar, Hemant <hemantp@ti.com> [110209 20:42]:
> Tony Lindgren wrote on Thursday, February 10, 2011 7:18 AM:
> 
> > * Tony Lindgren <tony@atomide.com> [110209 17:45]:
> >> 
> >> We should just have separate struct map_desc omapti816x_io_desc[] then.
> >> Maybe have a common struct map_desc omap3_io_desc[] and then separate
> >> omap3xxx_io_desc and omapti816x_io_desc?
> > 
> > Oh and this will work just fine for map_io without having cpu_is_omap
> > macros working yet because we call set_globals from the board
> > file with
> > the processor class data.
> > 
> > Tony
> 
> So probably I need to create another function (ti816x_map_common_io()) to
> map just the L4 slow region and call it from board file (after set globals)
> as distinguishing between OMAP3xxx and TI816X is not possible at that time
> inside omap34xx_map_common_io() as they both have same class.
> 
> Does this approach look ok?

Yes that's the way to go if the io regions are different.

Regards,

Tony

      reply	other threads:[~2011-02-10 17:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09 16:56 [PATCH v5 2/4] TI816X: Update common OMAP machine specific sources Hemant Pedanekar
2011-02-10  1:45 ` Tony Lindgren
2011-02-10  1:48   ` Tony Lindgren
2011-02-10  4:43     ` Pedanekar, Hemant
2011-02-10 17:02       ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110210170202.GK20795@atomide.com \
    --to=tony@atomide.com \
    --cc=hemantp@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.