From: Greg KH <gregkh@suse.de>
To: Tomas Winkler <tomasw@gmail.com>
Cc: Oren Weil <oren.jer.weil@intel.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
david@woodhou.se, david.woodhouse@intel.com
Subject: Re: [RFC PATCH 00/13] Intel(R) MEI Driver
Date: Thu, 10 Feb 2011 10:47:13 -0800 [thread overview]
Message-ID: <20110210184713.GA15882@suse.de> (raw)
In-Reply-To: <AANLkTimyxSy2FDBjh-xR1XmuZ9c7KjYHN-CjFAfp4Eu_@mail.gmail.com>
On Thu, Feb 10, 2011 at 08:43:57PM +0200, Tomas Winkler wrote:
> On Thu, Feb 10, 2011 at 7:58 PM, Greg KH <gregkh@suse.de> wrote:
> > On Thu, Feb 10, 2011 at 01:54:54AM -0800, Oren Weil wrote:
> >> Intel(R) Management Engine Interface (Intel(R) MEI) Driver
> >> ==========================================================
> >>
> >> This patch contains a new Intel driver for the Linux kernel: The Intel(R) MEI Driver.
> >
> > This patch? What patch, there is no patch here.
> >
> > You sent out 13 emails with the same exact Subject line, which is not
> > acceptable at all, and mighty confusing.
> >
> >> This set of patches is for review purposes; the driver code
> >> for pull is in the David Woodhouse public git repository:
> >> http://git.infradead.org/linux-2.6-mei.git
> >
> > No, we need these as patches, not as a pull request. Please work on
> > fixing up your individual patches, that's the only way this is going to
> > be accepted.
>
> There was a suggestion of splitting the driver into per file patches
> to be reviewable rather then creating gigantic driver patch.
> I personally would prefer the later one would happy to here any other
> suggestions how to split driver.
Per-file is ok, but just provide proper documentation, don't break the
build, and do it the correct way, like everyone else does every day.
This isn't something new people...
greg k-h
next prev parent reply other threads:[~2011-02-10 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 9:54 [RFC PATCH 00/13] Intel(R) MEI Driver Oren Weil
2011-02-10 17:58 ` Greg KH
2011-02-10 18:43 ` Tomas Winkler
2011-02-10 18:47 ` Greg KH [this message]
2011-02-10 19:14 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110210184713.GA15882@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david.woodhouse@intel.com \
--cc=david@woodhou.se \
--cc=linux-kernel@vger.kernel.org \
--cc=oren.jer.weil@intel.com \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.