All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Klaas Neirinck <klaas.neirinck@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: tidspbridge: fixed several coding style issues
Date: Fri, 11 Feb 2011 11:01:38 +0300	[thread overview]
Message-ID: <20110211080138.GG4384@bicker> (raw)
In-Reply-To: <1297382566-18748-1-git-send-email-klaas.neirinck@gmail.com>

On Fri, Feb 11, 2011 at 01:02:46AM +0100, Klaas Neirinck wrote:
> Fixed several coding style issues.
> 
> Signed-off-by: Klaas Neirinck <klaas.neirinck@gmail.com>
---  				dest = ibuf.bufr;
>  #ifdef OPT_ZERO_COPY_LOADER
>  				zero_copy = false;
> -				if (!dload_check_type(sptr, DLOAD_CINIT) {
> +				if (!dload_check_type(sptr, DLOAD_CINIT)) {
>  					dlthis->myio->writemem(dlthis->myio,
>  							       &dest,

Also it apparently fixes a compile problem?  Why not say that in the
change log...  :/

regards,
dan carpenter


  parent reply	other threads:[~2011-02-11  8:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-11  0:02 [PATCH] Staging: tidspbridge: fixed several coding style issues Klaas Neirinck
2011-02-11  1:18 ` Greg KH
2011-02-11  8:01 ` Dan Carpenter [this message]
2011-02-17 21:21   ` Ramirez Luna, Omar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110211080138.GG4384@bicker \
    --to=error27@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=klaas.neirinck@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.