From: Nathan Froyd <froydnj@codesourcery.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 1/2] target-arm: Move Neon VUZP to a helper function
Date: Fri, 11 Feb 2011 09:14:54 -0800 [thread overview]
Message-ID: <20110211171454.GQ6247@codesourcery.com> (raw)
In-Reply-To: <AANLkTinSMVtohnyApqmAcZ1t5AYGJmx_8H2tU49oxXME@mail.gmail.com>
On Fri, Feb 11, 2011 at 05:12:32PM +0000, Peter Maydell wrote:
> On 11 February 2011 17:03, Nathan Froyd <froydnj@codesourcery.com> wrote:
> > I do think the preferred way would be to extract rd, rm, size, and Q
> > up-front, rather than having the helper twiddle instruction bits.
>
> OK. You're happy to still have the helper do the reading and
> writing of env->vfp.regs[] directly, though?
I think you can make a case either way, but you're passing enough values
already that accessing env->vfp.regs directly in the helper seems
reasonable.
-Nathan
next prev parent reply other threads:[~2011-02-11 17:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 16:13 [Qemu-devel] [PATCH 0/2] target-arm: fix Neon VUZP, VZIP instructions Peter Maydell
2011-02-11 16:14 ` [Qemu-devel] [PATCH 1/2] target-arm: Move Neon VUZP to a helper function Peter Maydell
2011-02-11 16:53 ` Peter Maydell
2011-02-11 17:03 ` Nathan Froyd
2011-02-11 17:12 ` Peter Maydell
2011-02-11 17:14 ` Nathan Froyd [this message]
2011-02-11 16:14 ` [Qemu-devel] [PATCH 2/2] target-arm: Move Neon VZIP " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110211171454.GQ6247@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.