From: Greg KH <gregkh@suse.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: ycwang <yenchengwang@gmail.com>,
dbrownell@users.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_mass_storage: fixed a macro coding style issue
Date: Fri, 11 Feb 2011 11:13:40 -0800 [thread overview]
Message-ID: <20110211191340.GA11733@suse.de> (raw)
In-Reply-To: <20110211185710.GB31385@core.coreip.homeip.net>
On Fri, Feb 11, 2011 at 10:57:10AM -0800, Dmitry Torokhov wrote:
> On Fri, Feb 11, 2011 at 09:39:18AM -0800, Greg KH wrote:
> > On Fri, Feb 11, 2011 at 11:36:32PM +0800, ycwang wrote:
> > > Fixed a macro coding style issue.
> >
> > What macro coding style issue did you fix? Please be more specific and
> > resend the patch with a more complete changelog entry.
> >
>
> It is simply incorrect as it adds do {} while (0) to the module
> parameter constructors which are used outside of functions.
>
> The change was never compiled.
Well, I was going to wait until the next iteration of the patch to let
the submitter know that, you just spoiled my fun of watching someone
send a obviously broken patch twice :)
It's the little things in life we live for...
thanks,
greg k-h
next prev parent reply other threads:[~2011-02-11 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 15:36 [PATCH] usb: gadget: f_mass_storage: fixed a macro coding style issue ycwang
2011-02-11 17:39 ` Greg KH
2011-02-11 18:57 ` Dmitry Torokhov
2011-02-11 19:13 ` Greg KH [this message]
[not found] ` <AANLkTim_ZiR_GuD3e6KixxtX+r9z0+y2D66VJBRpp1ab@mail.gmail.com>
2011-02-12 16:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110211191340.GA11733@suse.de \
--to=gregkh@suse.de \
--cc=dbrownell@users.sourceforge.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yenchengwang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.