All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Jeff King <peff@peff.net>
Cc: xiaozhu <xiaozhu@gmail.com>, git@vger.kernel.org
Subject: Re: a bug about format-patch of multibyte characters comment
Date: Sun, 13 Feb 2011 10:48:58 +0100	[thread overview]
Message-ID: <201102131048.58111.j6t@kdbg.org> (raw)
In-Reply-To: <20110213075337.GA12112@sigill.intra.peff.net>

On Sonntag, 13. Februar 2011, Jeff King wrote:
> On Sat, Feb 12, 2011 at 07:13:15PM +0900, xiaozhu wrote:
> > Subject: [PATCH]
> > =?UTF-8?q?=E6=97=A5=E6=9C=AC=E8=AA=9E=E3=81=8C=E5=A4=A7=E4=B8=88=E5=A4=AB
> > =20=E6=94=B9=E8=A1=8C=E3=81=99=E3=82=8B?=
>
> Yeah, this is wrong. There should be a whitespace indentation in a
> multi-line header, or the whole thing should be on one line. The newline
> in your commit subject is apparently leaking through, and it should be
> qp-encoded.

Isn't it wrong that format-patch (and --pretty=email) does any quoting in the 
first place? Isn't it the task of the MUA (git-send-email) to do the quoting?

For example, when I import a format-patch generated patch into a mail message, 
I don't want to see:

 From: =?UTF-8?q?Joh=C3=A4nnes=20S=C3=BCxt?= <me@localhost>

but rather:

 From: Johännes Süxt <me@localhost>

I know this is a bit late, but this really comes as a surprise. (I've never 
had to pay attention to this behavior in the past...)

-- Hannes

  parent reply	other threads:[~2011-02-13  9:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-12 10:13 a bug about format-patch of multibyte characters comment xiaozhu
2011-02-12 12:30 ` "Martin Krüger"
2011-02-13  7:53 ` Jeff King
2011-02-13  8:31   ` Jeff King
2011-02-13  8:45     ` xiaozhu
2011-02-13  8:52       ` Jeff King
2011-02-13 10:14         ` xiaozhu
2011-02-13 10:22           ` xzer
2011-02-13 10:26             ` Jeff King
2011-02-13 10:50               ` xiaozhu
2011-02-13 10:23           ` Jeff King
2011-02-13  9:48   ` Johannes Sixt [this message]
2011-02-13 10:03     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201102131048.58111.j6t@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=xiaozhu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.