From: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH] drm/nouveau: fix __nouveau_fence_wait performance regression
Date: Sun, 13 Feb 2011 21:38:04 +0100 [thread overview]
Message-ID: <20110213203804.GA5395@joi.lan> (raw)
Combination of locking and interchannel synchronization changes
uncovered poor behaviour of nouveau_fence_wait, which on HZ=100
configuration could waste up to 10 ms per call.
Depending on application, it lead to 10-30% FPS regression.
To fix it, shorten thread sleep time to 0.1 ms and ensure
spinning happens for at least one *full* tick.
Signed-off-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/gpu/drm/nouveau/nouveau_fence.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c
index 221b846..75ba5e2 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fence.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
@@ -27,6 +27,9 @@
#include "drmP.h"
#include "drm.h"
+#include <linux/ktime.h>
+#include <linux/hrtimer.h>
+
#include "nouveau_drv.h"
#include "nouveau_ramht.h"
#include "nouveau_dma.h"
@@ -230,9 +233,12 @@ int
__nouveau_fence_wait(void *sync_obj, void *sync_arg, bool lazy, bool intr)
{
unsigned long timeout = jiffies + (3 * DRM_HZ);
- unsigned long sleep_time = jiffies + 1;
+ unsigned long sleep_time = jiffies + 2;
+ ktime_t t;
int ret = 0;
+ t = ktime_set(0, NSEC_PER_MSEC / 10);
+
while (1) {
if (__nouveau_fence_signalled(sync_obj, sync_arg))
break;
@@ -245,7 +251,7 @@ __nouveau_fence_wait(void *sync_obj, void *sync_arg, bool lazy, bool intr)
__set_current_state(intr ? TASK_INTERRUPTIBLE
: TASK_UNINTERRUPTIBLE);
if (lazy && time_after_eq(jiffies, sleep_time))
- schedule_timeout(1);
+ schedule_hrtimeout(&t, HRTIMER_MODE_REL);
if (intr && signal_pending(current)) {
ret = -ERESTARTSYS;
--
1.7.4.rc3
next reply other threads:[~2011-02-13 20:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-13 20:38 Marcin Slusarz [this message]
[not found] ` <20110213203804.GA5395-OI9uyE9O0yo@public.gmane.org>
2011-02-21 12:40 ` [PATCH] drm/nouveau: fix __nouveau_fence_wait performance regression Marcin Slusarz
2011-03-04 16:49 ` Marcin Slusarz
[not found] ` <20110304164905.GA2743-OI9uyE9O0yo@public.gmane.org>
2011-03-07 18:18 ` Maarten Maathuis
[not found] ` <AANLkTin_jouzPDGfNnYq_BRqPzbvOW+F6jFNuc7p=p5E-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-07 22:24 ` Ben Skeggs
2011-03-07 23:22 ` Marcin Slusarz
[not found] ` <20110307232256.GA2680-OI9uyE9O0yo@public.gmane.org>
2011-03-07 23:27 ` Marcin Slusarz
[not found] ` <20110307232719.GB2680-OI9uyE9O0yo@public.gmane.org>
2011-03-08 0:34 ` Ben Skeggs
2011-03-08 0:58 ` Francisco Jerez
[not found] ` <87lj0qzaut.fsf-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org>
2011-03-08 12:16 ` Marcin Slusarz
[not found] ` <20110308121628.GA20238-OI9uyE9O0yo@public.gmane.org>
2011-03-08 16:22 ` Francisco Jerez
[not found] ` <871v2hzin7.fsf-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org>
2011-03-09 0:14 ` Marcin Slusarz
[not found] ` <20110309001404.GA22679-OI9uyE9O0yo@public.gmane.org>
2011-03-09 17:34 ` Francisco Jerez
[not found] ` <87fwqwb3kj.fsf-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org>
2011-03-09 18:04 ` Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110213203804.GA5395@joi.lan \
--to=marcin.slusarz-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.