From mboxrd@z Thu Jan 1 00:00:00 1970 From: Casey Leedom Subject: Re: [PATCH net-26 1/5] cxgb4vf: Virtual Interfaces are always up ... Date: Mon, 14 Feb 2011 14:31:32 -0800 Message-ID: <201102141431.32535.leedom@chelsio.com> References: <1297472423-15672-1-git-send-email-leedom@chelsio.com> <20110211.211939.70197667.davem@davemloft.net> <201102141113.58068.leedom@chelsio.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: David Miller Return-path: Received: from stargate.chelsio.com ([67.207.112.58]:7907 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750948Ab1BNWbe (ORCPT ); Mon, 14 Feb 2011 17:31:34 -0500 In-Reply-To: <201102141113.58068.leedom@chelsio.com> Sender: netdev-owner@vger.kernel.org List-ID: | From: Casey Leedom | Date: Monday, February 14, 2011 11:13 am | | | No driver specific module parameters! Add something generic and common | | so other drivers can use it too. | | | | Otherwise every user has to learn a different way to control this | | attribute, depending upon the device type, which is rediculious. | | | | How many times do we have to tell driver authors this? | | Sorry. I wasn't aware of this rule. My bad. Is this writeen down | somewhere under Documentation? I'm not being snarky. I really would like | to know so I can read through the general ground rules and avoid making | more mistakes in the future. | | As for a generic mechanism, what's the preferred way of doing this? A | new ethtool flag? Sorry for being a doofus here, I'm happy to follow | whatever the accepted standard is. Thanks for your time and patience. Also, I assume then the the entire patch series is now rejected, right? And that I should resubmit the patch series without the unacceptable module parameter, right? I'm just trying to figure out what I need to do next. Thanks. Casey