diff for duplicates of <201102141756.19068.marek.vasut@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 46019d7..730e321 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -24,7 +24,7 @@ On Sunday 13 February 2011 13:12:12 Julia Lawall wrote: > * release_resource(x); > // </smpl> > -> Signed-off-by: Julia Lawall <julia@diku.dk> +> Signed-off-by: Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org> > > --- > Not compiled due to incompatible architecture. @@ -43,7 +43,7 @@ On Sunday 13 February 2011 13:12:12 Julia Lawall wrote: > - i2c->ioarea = request_mem_region(res->start, resource_size(res), > - pdev->name); > - -> - if (i2c->ioarea = NULL) { +> - if (i2c->ioarea == NULL) { > + if (!request_mem_region(res->start, resource_size(res), pdev->name)) { I prefer the original version here -- it's clearer and also, doesn't the new @@ -57,7 +57,7 @@ version violate line-over-80 principle ? > + i2c->ioarea = res; > i2c->regs = ioremap(res->start, resource_size(res)); > -> if (i2c->regs = NULL) { +> if (i2c->regs == NULL) { > @@ -645,8 +643,7 @@ static int __devinit nuc900_i2c_probe(struct > platform_device *pdev) iounmap(i2c->regs); > diff --git a/a/content_digest b/N1/content_digest index f2717d5..676ae81 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,9 @@ "ref\01297599132-7226-1-git-send-email-julia@diku.dk\0" "ref\01297599132-7226-6-git-send-email-julia@diku.dk\0" "ref\01297599132-7226-6-git-send-email-julia-dAYI7NvHqcQ@public.gmane.org\0" - "From\0Marek Vasut <marek.vasut@gmail.com>\0" - "Subject\0Re: [PATCH 5/5] drivers/i2c/busses/i2c-nuc900.c: Convert release_resource to release_region/release_\0" - "Date\0Mon, 14 Feb 2011 16:56:18 +0000\0" + "From\0Marek Vasut <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" + "Subject\0Re: [PATCH 5/5] drivers/i2c/busses/i2c-nuc900.c: Convert release_resource to release_region/release_mem_region\0" + "Date\0Mon, 14 Feb 2011 17:56:18 +0100\0" "To\0Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org>\0" "Cc\0ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org" kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org @@ -39,7 +39,7 @@ "> * release_resource(x);\n" "> // </smpl>\n" "> \n" - "> Signed-off-by: Julia Lawall <julia@diku.dk>\n" + "> Signed-off-by: Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org>\n" "> \n" "> ---\n" "> Not compiled due to incompatible architecture.\n" @@ -58,7 +58,7 @@ "> -\ti2c->ioarea = request_mem_region(res->start, resource_size(res),\n" "> -\t\t\t\t\t pdev->name);\n" "> -\n" - "> -\tif (i2c->ioarea = NULL) {\n" + "> -\tif (i2c->ioarea == NULL) {\n" "> +\tif (!request_mem_region(res->start, resource_size(res), pdev->name)) {\n" "\n" "I prefer the original version here -- it's clearer and also, doesn't the new \n" @@ -72,7 +72,7 @@ "> +\ti2c->ioarea = res;\n" "> \ti2c->regs = ioremap(res->start, resource_size(res));\n" "> \n" - "> \tif (i2c->regs = NULL) {\n" + "> \tif (i2c->regs == NULL) {\n" "> @@ -645,8 +643,7 @@ static int __devinit nuc900_i2c_probe(struct\n" "> platform_device *pdev) iounmap(i2c->regs);\n" "> \n" @@ -109,4 +109,4 @@ "> \n" "> \treturn 0;" -4a4365c0f467c9359a2151d6521b05132a74700cc417ac2c3c4768907249ae3c +d11495463603a3cd35ef18bbf860ce2d8ab257d1546c9d339d0d59896abbbdf9
diff --git a/a/1.txt b/N2/1.txt index 46019d7..236c49e 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -43,7 +43,7 @@ On Sunday 13 February 2011 13:12:12 Julia Lawall wrote: > - i2c->ioarea = request_mem_region(res->start, resource_size(res), > - pdev->name); > - -> - if (i2c->ioarea = NULL) { +> - if (i2c->ioarea == NULL) { > + if (!request_mem_region(res->start, resource_size(res), pdev->name)) { I prefer the original version here -- it's clearer and also, doesn't the new @@ -57,7 +57,7 @@ version violate line-over-80 principle ? > + i2c->ioarea = res; > i2c->regs = ioremap(res->start, resource_size(res)); > -> if (i2c->regs = NULL) { +> if (i2c->regs == NULL) { > @@ -645,8 +643,7 @@ static int __devinit nuc900_i2c_probe(struct > platform_device *pdev) iounmap(i2c->regs); > diff --git a/a/content_digest b/N2/content_digest index f2717d5..d329e58 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,16 +1,15 @@ "ref\01297599132-7226-1-git-send-email-julia@diku.dk\0" "ref\01297599132-7226-6-git-send-email-julia@diku.dk\0" - "ref\01297599132-7226-6-git-send-email-julia-dAYI7NvHqcQ@public.gmane.org\0" "From\0Marek Vasut <marek.vasut@gmail.com>\0" - "Subject\0Re: [PATCH 5/5] drivers/i2c/busses/i2c-nuc900.c: Convert release_resource to release_region/release_\0" - "Date\0Mon, 14 Feb 2011 16:56:18 +0000\0" - "To\0Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org>\0" - "Cc\0ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org" - kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> - Dave Airlie <airlied-cv59FeDIM0c@public.gmane.org> - linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - " linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" + "Subject\0Re: [PATCH 5/5] drivers/i2c/busses/i2c-nuc900.c: Convert release_resource to release_region/release_mem_region\0" + "Date\0Mon, 14 Feb 2011 17:56:18 +0100\0" + "To\0Julia Lawall <julia@diku.dk>\0" + "Cc\0ben-linux@fluff.org" + kernel-janitors@vger.kernel.org + Baruch Siach <baruch@tkos.co.il> + Dave Airlie <airlied@linux.ie> + linux-i2c@vger.kernel.org + " linux-kernel@vger.kernel.org\0" "\00:1\0" "b\0" "On Sunday 13 February 2011 13:12:12 Julia Lawall wrote:\n" @@ -58,7 +57,7 @@ "> -\ti2c->ioarea = request_mem_region(res->start, resource_size(res),\n" "> -\t\t\t\t\t pdev->name);\n" "> -\n" - "> -\tif (i2c->ioarea = NULL) {\n" + "> -\tif (i2c->ioarea == NULL) {\n" "> +\tif (!request_mem_region(res->start, resource_size(res), pdev->name)) {\n" "\n" "I prefer the original version here -- it's clearer and also, doesn't the new \n" @@ -72,7 +71,7 @@ "> +\ti2c->ioarea = res;\n" "> \ti2c->regs = ioremap(res->start, resource_size(res));\n" "> \n" - "> \tif (i2c->regs = NULL) {\n" + "> \tif (i2c->regs == NULL) {\n" "> @@ -645,8 +643,7 @@ static int __devinit nuc900_i2c_probe(struct\n" "> platform_device *pdev) iounmap(i2c->regs);\n" "> \n" @@ -109,4 +108,4 @@ "> \n" "> \treturn 0;" -4a4365c0f467c9359a2151d6521b05132a74700cc417ac2c3c4768907249ae3c +87ae4f9e203abefd933e233891c8f9176497e5399b0536497baaab0251e44030
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.