From: Dan Carpenter <error27@gmail.com>
To: Roland Vossen <rvossen@broadcom.com>
Cc: s@fomichev.me, gregkh@suse.de,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] brcm80211: remove multiple calls to wl_release_fw
Date: Mon, 14 Feb 2011 23:22:49 +0300 [thread overview]
Message-ID: <20110214202249.GK4384@bicker> (raw)
In-Reply-To: <4D598993.4020900@broadcom.com>
> On 02/12/2011 04:00 PM, Stanislav Fomichev wrote:
> >This causes an oops when the bcm43xx_hdr-0.fw binary is not found.
> >
This patch isn't right. It fixes the oops but it introduces some leaks.
(We still need to release firmware that was allocated successfully).
regards,
dan carpenter
next prev parent reply other threads:[~2011-02-14 20:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-12 15:00 [PATCH] brcm80211: remove multiple calls to wl_release_fw Stanislav Fomichev
2011-02-14 19:59 ` Roland Vossen
2011-02-14 20:22 ` Dan Carpenter [this message]
2011-02-14 20:40 ` Roland Vossen
2011-02-14 21:03 ` Stanislav Fomichev
2011-02-14 21:07 ` Stanislav Fomichev
2011-02-14 21:20 ` Dan Carpenter
2011-02-18 20:57 ` Greg KH
2011-02-19 9:03 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110214202249.GK4384@bicker \
--to=error27@gmail.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
--cc=rvossen@broadcom.com \
--cc=s@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.