From: Greg KH <greg@kroah.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Tirumala Marri <tmarri@apm.com>,
linux-usb@vger.kernel.org,
Alexander Gordeev <lasaine@lvk.cs.msu.su>,
Mark Miesfeld <mmiesfeld@apm.com>,
linuxppc-dev@lists.ozlabs.org, Fushen Chen <fchen@apm.com>
Subject: Re: [PATCH V8 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core InterfaceLayer
Date: Mon, 14 Feb 2011 17:04:16 -0800 [thread overview]
Message-ID: <20110215010416.GA16060@kroah.com> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6D8AC4D@saturn3.aculab.com>
On Mon, Feb 14, 2011 at 08:53:21AM -0000, David Laight wrote:
>
> > > Sorry, I don't understand that. I think u32 is always 32bit
> > > 4byte on all archs. Right?
> >
> > Yes.
> >
> > Use an unsigned long if you want to hold a pointer correctly on all
> > arches.
>
> Although that is true for many systems (and probably all ppc Linux)
> it isn't necessarily true (eg 64 bit Microsoft Windows).
Again, it is true for all Linux architectures. We aren't caring about
any other operating systems here, sorry.
> C99 inttypes.h should define uintptr_t as an unsigned integer
> type that is large enough to hold a (data) pointer.
> I'm not sure if this is defined for the Linux kernel.
uint* aren't to be used within the kernel as they make no sense.
thanks,
greg k-h
next prev parent reply other threads:[~2011-02-15 1:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 22:57 [PATCH V8 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer tmarri
2011-01-26 16:17 ` Alexander Gordeev
2011-01-26 16:35 ` [PATCH V8 03/10] USB/ppc4xx: Add Synopsys DWC OTG CoreInterface Layer David Laight
2011-01-26 17:35 ` Alexander Gordeev
2011-02-07 18:45 ` Tirumala Marri
2011-02-07 18:53 ` [PATCH V8 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer Tirumala Marri
2011-02-08 0:19 ` Alexander Gordeev
2011-02-08 1:30 ` Greg KH
2011-02-11 18:33 ` Tirumala Marri
2011-02-14 8:53 ` [PATCH V8 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core InterfaceLayer David Laight
2011-02-14 11:34 ` Alexander Gordeev
2011-02-15 1:04 ` Greg KH [this message]
2011-02-08 8:58 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110215010416.GA16060@kroah.com \
--to=greg@kroah.com \
--cc=David.Laight@ACULAB.COM \
--cc=fchen@apm.com \
--cc=lasaine@lvk.cs.msu.su \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mmiesfeld@apm.com \
--cc=tmarri@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.