From: Christoph Hellwig <hch@infradead.org>
To: Jim Rees <rees@umich.edu>
Cc: "J. Bruce Fields" <bfields@redhat.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/6] nfsd4: split up nfsd_break_deleg_cb
Date: Tue, 15 Feb 2011 06:14:04 -0500 [thread overview]
Message-ID: <20110215111404.GA12517@infradead.org> (raw)
In-Reply-To: <20110209162838.GA21056@merit.edu>
On Wed, Feb 09, 2011 at 11:28:38AM -0500, Jim Rees wrote:
> J. Bruce Fields wrote:
>
> Agreed. Those two lines were actually untouched by this patch, no
> matter what diff thinks--but I'm just as happy to fix it up while we're
> there; done.
>
> I agree too, but "indent -linux" likes "static" on a line by itself, and
> prefers it over "static void". This is not the first time I've disagreed
> with it, although I use it a lot.
The linux styles of most indent-like programs are utter garbage. If you
want Linux style use the scripts/Lindent script in the source tree. It
still has a few quirks, like stupid ways to split overly long lines, but
generally does a reasonable job.
next prev parent reply other threads:[~2011-02-15 11:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 4:55 Fix a 2.6.38 delegation regression J. Bruce Fields
2011-02-09 4:55 ` [PATCH 1/6] nfsd4: split up nfsd_break_deleg_cb J. Bruce Fields
2011-02-09 5:01 ` Christoph Hellwig
2011-02-09 15:14 ` J. Bruce Fields
2011-02-09 16:28 ` Jim Rees
2011-02-15 11:14 ` Christoph Hellwig [this message]
2011-02-15 12:09 ` Jim Rees
2011-02-09 4:55 ` [PATCH 2/6] nfsd4: add helper function for lease setup J. Bruce Fields
2011-02-09 4:55 ` [PATCH 3/6] nfsd4: fix leak on allocation error J. Bruce Fields
2011-02-09 4:55 ` [PATCH 4/6] nfsd4: split lease setting into separate function J. Bruce Fields
2011-02-09 4:55 ` [PATCH 5/6] nfsd4: remove unused deleg dprintk's J. Bruce Fields
2011-02-09 4:55 ` [PATCH 6/6] nfsd4: modify fi_delegations under recall_lock J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110215111404.GA12517@infradead.org \
--to=hch@infradead.org \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.