Re: [PATCH] iwlwifi: zero fill txq->txb on queue reset

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Tue, Feb 15, 2011 at 12:48:02PM +0100, Johannes Berg wrote:
> On Tue, 2011-02-15 at 12:39 +0100, Stanislaw Gruszka wrote:
> 
> > > > >  	if (txq_id == priv->cmd_queue)
> > > > >  		actual_slots++;
> > > > > +	else
> > > > > +		memset(txq->txb, 0, sizeof(txq->txb[0]) * TFD_QUEUE_SIZE_MAX);
> > > > 
> > > > I don't mind -- but I think the changelog should say that this isn't
> > > > necessary since the device will never use any of those entries?
> > > 
> > > Err, I confused txb and tfds. But it still shouldn't be necessary --
> > > aren't the entries reset to NULL when taken out of use?
> > 
> > There are memset zero before the use in {iwlagn,iwl3945}_tx_skb(),
> > so patch is unneeded as well kzalloc in current code (I add replace
> > to kmalloc to my todo list).
> 
> Well, don't worry, the change is fine -- 

hmm, I think is not, it just add more confusion

Stanislaw