All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Cc: linux-wireless@vger.kernel.org, Daniel Drake <dsd@gentoo.org>,
	Ulrich Kunitz <kune@deine-taler.de>
Subject: Re: [PATCH] zd1211rw: change endpoint types of EP_REGS_OUT and EP_INT_IN from interrupt to bulk
Date: Tue, 15 Feb 2011 13:49:46 -0500	[thread overview]
Message-ID: <20110215184945.GF2557@tuxdriver.com> (raw)
In-Reply-To: <20110206083522.16858.24185.stgit@fate.lan>

On Sun, Feb 06, 2011 at 10:35:22AM +0200, Jussi Kivilinna wrote:
> This fixes high CPU usage when writing beacon frame to hardware. With this
> patch CPU usage of kworker on Intel Atom with 100 TU beacon interval goes
> from ~10% down to <1%.
> 
> Checking vendor driver appears it's also ignoring fact that endpoints are
> interrupt type and is using bulk urbs on these.
> 
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>

This patch led to a lengthy thread.  I'm not 100% clear on the
outcome, but it seems like the conclusion was that the driver should
be doing something else -- at least that seemed to be the conclusion
for ath9k_htc.

So, is this patch still wanted?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  parent reply	other threads:[~2011-02-15 19:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-06  8:35 [PATCH] zd1211rw: change endpoint types of EP_REGS_OUT and EP_INT_IN from interrupt to bulk Jussi Kivilinna
2011-02-06  9:16 ` Sujith
2011-02-06 11:35   ` Jussi Kivilinna
2011-02-15 18:49 ` John W. Linville [this message]
2011-02-16  1:08   ` Jussi Kivilinna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110215184945.GF2557@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=dsd@gentoo.org \
    --cc=jussi.kivilinna@mbnet.fi \
    --cc=kune@deine-taler.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.