All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: "Elvis Pfützenreuter" <epx@signove.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Move HealthManager Interface to "/" path
Date: Tue, 15 Feb 2011 17:11:23 -0300	[thread overview]
Message-ID: <20110215201123.GC7219@joana> (raw)
In-Reply-To: <9C50502C-696A-45DE-B306-8421FE18F897@signove.com>

* Elvis Pfützenreuter <epx@signove.com> [2011-02-15 17:45:05 -0200]:

> Hi Padovan,
> 
> On Feb 15, 2011, at 5:31 PM, Gustavo F. Padovan wrote:
> 
> > Yeah, this breaks the API, but health is still disabled by default and it
> > is not a good idea create a new path only for it. So moving it to "/"
> > ---
> > doc/health-api.txt    |    2 +-
> > health/hdp.c          |    4 ++--
> > test/test-health      |    2 +-
> > test/test-health-sink |    2 +-
> > 4 files changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/doc/health-api.txt b/doc/health-api.txt
> > index 3d0a717..9d5a54d 100644
> > --- a/doc/health-api.txt
> > +++ b/doc/health-api.txt
> > @@ -10,7 +10,7 @@ Health Device Profile hierarchy
> > 
> > Service		org.bluez
> > Interface	org.bluez.HealthManager
> > -Object path	/org/bluez/
> > +Object path	/
> > 
> > Methods:
> > 
> > diff --git a/health/hdp.c b/health/hdp.c
> > index d4a2a30..e58bd55 100644
> > --- a/health/hdp.c
> > +++ b/health/hdp.c
> > @@ -2171,7 +2171,7 @@ int hdp_manager_start(DBusConnection *conn)
> > {
> > 	DBG("Starting Health manager");
> > 
> > -	if (!g_dbus_register_interface(conn, MANAGER_PATH,
> > +	if (!g_dbus_register_interface(conn, "/",
> 
> I'd rather change macro value instead of removing it. Patch gets smaller. 
> (Or remove the macro definition along with its references.)

Yeah, I forgot to remove the macro definition.

-- 
Gustavo F. Padovan
http://profusion.mobi

  parent reply	other threads:[~2011-02-15 20:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-15 19:31 [PATCH] Move HealthManager Interface to "/" path Gustavo F. Padovan
2011-02-15 19:35 ` Luiz Augusto von Dentz
2011-02-15 19:59   ` Gustavo F. Padovan
2011-02-16 12:18     ` Jose Antonio Santos Cadenas
     [not found] ` <9C50502C-696A-45DE-B306-8421FE18F897@signove.com>
2011-02-15 20:11   ` Gustavo F. Padovan [this message]
2011-02-16 12:28 ` Jose Antonio Santos Cadenas
2011-02-16 12:32   ` Jose Antonio Santos Cadenas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110215201123.GC7219@joana \
    --to=padovan@profusion.mobi \
    --cc=epx@signove.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.