All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [v2] powerpc: clean up DIU macro definitions for the MPC8610HPCD and MPC5121ADS
Date: Tue, 15 Feb 2011 23:01:32 +0100	[thread overview]
Message-ID: <20110215220132.2CAD7101D41@gemini.denx.de> (raw)
In-Reply-To: <1297807109-21948-1-git-send-email-timur@freescale.com>

Dear Timur Tabi,

In message <1297807109-21948-1-git-send-email-timur@freescale.com> you wrote:
> Clean up the macro defintions used to enable DIU (video) support on the
> MPC8610HPCD and the MPC5121ADS so that they look more like the P1022DS,
> which is newer.
> 
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
>  include/configs/MPC8610HPCD.h |   12 ++++--------
>  include/configs/mpc5121ads.h  |    8 ++++----
>  2 files changed, 8 insertions(+), 12 deletions(-)
> 
> diff --git a/include/configs/MPC8610HPCD.h b/include/configs/MPC8610HPCD.h
> index 03ee394..8022895 100644
> --- a/include/configs/MPC8610HPCD.h
> +++ b/include/configs/MPC8610HPCD.h
> @@ -21,12 +21,13 @@
>  
>  #define	CONFIG_SYS_TEXT_BASE	0xfff00000
>  
> -#define CONFIG_FSL_DIU_FB	1	/* FSL DIU */
>  
>  /* video */
> -#undef CONFIG_VIDEO
> +/* #define CONFIG_FSL_DIU_FB */

Please do not add dead code.

> diff --git a/include/configs/mpc5121ads.h b/include/configs/mpc5121ads.h
> index f966325..01dd096 100644
> --- a/include/configs/mpc5121ads.h
> +++ b/include/configs/mpc5121ads.h
> @@ -46,14 +46,15 @@
>   */
>  #define CONFIG_E300		1	/* E300 Family */
>  #define CONFIG_MPC512X		1	/* MPC512X family */
> -#define CONFIG_FSL_DIU_FB	1	/* FSL DIU */
>  
>  #define	CONFIG_SYS_TEXT_BASE	0xFFF00000
>  
>  /* video */
> -#undef CONFIG_VIDEO
> +/* #define CONFIG_FSL_DIU_FB */

Ditto.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No man knows what true happiness is until he gets married.  By  then,
of course, its too late.

  reply	other threads:[~2011-02-15 22:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-15 21:58 [U-Boot] [PATCH] [v2] powerpc: clean up DIU macro definitions for the MPC8610HPCD and MPC5121ADS Timur Tabi
2011-02-15 22:01 ` Wolfgang Denk [this message]
2011-02-15 22:05   ` Timur Tabi
2011-02-15 22:15     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110215220132.2CAD7101D41@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.