From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Koul, Vinod" <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org,
Harsha Priya <priya.harsha@intel.com>,
lrg@slimlogic.co.uk
Subject: Re: [PATCH 4/5] ASoC: sst_platform: fix the pulseaudio error
Date: Tue, 15 Feb 2011 17:57:15 -0800 [thread overview]
Message-ID: <20110216015714.GA3021@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1297774735-32184-5-git-send-email-vinod.koul@intel.com>
On Tue, Feb 15, 2011 at 06:28:54PM +0530, Koul, Vinod wrote:
> From: Vinod Koul <vinod.koul@intel.com>
>
> Pulseaudio doesnt work with current driver and it was root caused to absense of
> hw_params function and malloc_pages in it.
> This patch adds this and allows pa to work fine with these drivers
For changes like this you really should provide changelogs which are
more specific about what the actual problem is - it's fine to say that
you found the problem while testing with PulseAudio but you really
should say what the problem you found was. This is more useful for both
review and for mining the changelog as it explains the change itself
rather than the circumstances in which it was created.
Anyway, I've applied the whole series - thanks!
next prev parent reply other threads:[~2011-02-16 1:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 12:58 [PATCH 0/5] mfld machine and codec fixes Koul, Vinod
2011-02-15 12:58 ` [PATCH 1/5] ASoC: sn95031: make playback rails depend on actual pins they control Koul, Vinod
2011-02-15 12:58 ` [PATCH 2/5] ASoC: sn95031: fix the DMIC path routing Koul, Vinod
2011-02-15 12:58 ` [PATCH 3/5] ASoC: sn95031: fix the amic tlv scale Koul, Vinod
2011-02-15 12:58 ` [PATCH 4/5] ASoC: sst_platform: fix the pulseaudio error Koul, Vinod
2011-02-15 14:46 ` Bensaid, Selma
2011-02-15 15:26 ` Koul, Vinod
2011-02-16 1:57 ` Mark Brown [this message]
2011-02-15 12:58 ` [PATCH 5/5] ASoC: mfld_machine: make use of soc_register_card API Koul, Vinod
2011-02-15 21:50 ` [PATCH 0/5] mfld machine and codec fixes Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110216015714.GA3021@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=priya.harsha@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.