All of lore.kernel.org
 help / color / mirror / Atom feed
diff for duplicates of <20110216145049.GC13872@ericsson.com>

diff --git a/a/1.txt b/N1/1.txt
index 8003d0e..6291db3 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -83,7 +83,7 @@ On Wed, Feb 16, 2011 at 08:02:38AM -0500, Clemens Ladisch wrote:
 > +	unsigned int config = data->config;
 > +	bool readonly;
 > +
-> +	if (attr = &dev_attr_temp1_crit.attr)
+> +	if (attr == &dev_attr_temp1_crit.attr)
 > +		readonly = config & JC42_CFG_TCRIT_LOCK;
 
 You are assigning a non-bool to a bool. I can see that recent C compilers
@@ -93,10 +93,10 @@ So I would prefer
 
 Same for the assignments below. I can make that change if you are ok with it.
 
-> +	else if (attr = &dev_attr_temp1_min.attr ||
-> +		 attr = &dev_attr_temp1_max.attr)
+> +	else if (attr == &dev_attr_temp1_min.attr ||
+> +		 attr == &dev_attr_temp1_max.attr)
 > +		readonly = config & JC42_CFG_EVENT_LOCK;
-> +	else if (attr = &dev_attr_temp1_crit_hyst.attr)
+> +	else if (attr == &dev_attr_temp1_crit_hyst.attr)
 > +		readonly = config & (JC42_CFG_EVENT_LOCK | JC42_CFG_TCRIT_LOCK);
 > +	else
 > +		readonly = true;
@@ -115,8 +115,3 @@ Same for the assignments below. I can make that change if you are ok with it.
 > lm-sensors mailing list
 > lm-sensors@lm-sensors.org
 > http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
-
-_______________________________________________
-lm-sensors mailing list
-lm-sensors@lm-sensors.org
-http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
diff --git a/a/content_digest b/N1/content_digest
index 5f7719c..75bb504 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -1,8 +1,8 @@
  "ref\04D5BCA87.7010204@ladisch.de\0"
  "ref\04D5BCAEE.6030502@ladisch.de\0"
  "From\0Guenter Roeck <guenter.roeck@ericsson.com>\0"
- "Subject\0Re: [lm-sensors] [PATCH 3/3] hwmon: (jc42) do not allow writing to\0"
- "Date\0Wed, 16 Feb 2011 14:50:49 +0000\0"
+ "Subject\0Re: [lm-sensors] [PATCH 3/3] hwmon: (jc42) do not allow writing to locked registers\0"
+ "Date\0Wed, 16 Feb 2011 06:50:49 -0800\0"
  "To\0Clemens Ladisch <clemens@ladisch.de>\0"
  "Cc\0Guenter Roeck <linux@roeck-us.net>"
   Jean Delvare <khali@linux-fr.org>
@@ -95,7 +95,7 @@
  "> +\tunsigned int config = data->config;\n"
  "> +\tbool readonly;\n"
  "> +\n"
- "> +\tif (attr = &dev_attr_temp1_crit.attr)\n"
+ "> +\tif (attr == &dev_attr_temp1_crit.attr)\n"
  "> +\t\treadonly = config & JC42_CFG_TCRIT_LOCK;\n"
  "\n"
  "You are assigning a non-bool to a bool. I can see that recent C compilers\n"
@@ -105,10 +105,10 @@
  "\n"
  "Same for the assignments below. I can make that change if you are ok with it.\n"
  "\n"
- "> +\telse if (attr = &dev_attr_temp1_min.attr ||\n"
- "> +\t\t attr = &dev_attr_temp1_max.attr)\n"
+ "> +\telse if (attr == &dev_attr_temp1_min.attr ||\n"
+ "> +\t\t attr == &dev_attr_temp1_max.attr)\n"
  "> +\t\treadonly = config & JC42_CFG_EVENT_LOCK;\n"
- "> +\telse if (attr = &dev_attr_temp1_crit_hyst.attr)\n"
+ "> +\telse if (attr == &dev_attr_temp1_crit_hyst.attr)\n"
  "> +\t\treadonly = config & (JC42_CFG_EVENT_LOCK | JC42_CFG_TCRIT_LOCK);\n"
  "> +\telse\n"
  "> +\t\treadonly = true;\n"
@@ -126,11 +126,6 @@
  "> _______________________________________________\n"
  "> lm-sensors mailing list\n"
  "> lm-sensors@lm-sensors.org\n"
- "> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors\n"
- "\n"
- "_______________________________________________\n"
- "lm-sensors mailing list\n"
- "lm-sensors@lm-sensors.org\n"
- http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
+ > http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
 
-6a5ffc4415fca8a918e518f69d66a590348f90178119427909f9cd31874ce706
+60753eede06bf583a9027c285a0addd4c9ed4bb0ee6e45f42449c95d1b36808b

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.