All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>, '@dumpdata.com
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: Re: [PATCH 1/2] xen: events: do not workaround too-small nr_irqs
Date: Wed, 16 Feb 2011 11:55:05 -0500	[thread overview]
Message-ID: <20110216165505.GB3904@dumpdata.com> (raw)
In-Reply-To: <1297872857.16356.266.camel@zakaz.uk.xensource.com>

On Wed, Feb 16, 2011 at 04:14:17PM +0000, Ian Campbell wrote:
> On Tue, 2011-02-15 at 15:15 +0000, Ian Campbell wrote:
> > On Wed, 2011-02-09 at 16:21 +0000, Konrad Rzeszutek Wilk wrote:
> > > On Wed, Feb 09, 2011 at 11:10:44AM +0000, Ian Campbell wrote:
> > > > This workaround was somewhat useful prior to the introduction of the
> > > > core irq allocator and 026c9d2d0d75 "xen: events: allocate GSIs and
> > > > dynamic IRQs from separate IRQ ranges." but should not be unnecessary now.
> > > > 
> > > > If nr_irqs turns out to be too small under Xen then we use (or define
> > > > if necessary) the interfaces to increase nr_irqs rather than working
> > > > around the core allocator in this way.
> > > > 
> > > > In my configuration NR_IRQS ends up being 2304 with nr_irq_gsi 272
> > > > which is sufficient.
> > > 
> > > Is this configuration where you run Xen + Linux under QEMU?
> > 
> > I've just tried these two patches under qemu, booting a 64 bit
> > xen-unstable hypervisor with a 32 bit domain 0 kernel, pxeboot using:
> >         qemu-system-x86_64 -m 256 -vnc 0.0.0.0:1 -k en-gb -serial stdio -boot nc \
> >         	-usb -usbdevice tablet -net nic,vlan=0,macaddr=00:16:3e:f7:c4:1d,model=e1000 \
> >         	-net tap,vlan=0,ifname=tapQEMU.0 -hda /dev/VG/debian-HVM-1 
> >         
> > There I appear to get:
> >         nr_irqs_gsi: 272
> >         NR_IRQS:2304 nr_irqs:256 16
> > 
> > which leads to a failure due to not being able to allocate a dynamic IRQ
> > (because 272 > 256!), I'll dig into this...
> 
> The solution is to increase nr_irqs, which is currently static after
> boot even with sparseirqs.
> 
> Fortunately tglx intends to make this dynamically growable in the IRQ
> core in the 2.6.39 time frame which nicely ties in with this patch.

OK. Can you point me to tglx's git tree that brings these goodies in?

  reply	other threads:[~2011-02-16 16:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09 11:09 [PATCH 0/2] xen: events: a couple of minor cleanups Ian Campbell
2011-02-09 11:10 ` [PATCH 1/2] xen: events: do not workaround too-small nr_irqs Ian Campbell
2011-02-09 16:21   ` Konrad Rzeszutek Wilk
2011-02-09 16:57     ` Ian Campbell
2011-02-15 15:15     ` Ian Campbell
2011-02-16 16:14       ` Ian Campbell
2011-02-16 16:55         ` Konrad Rzeszutek Wilk [this message]
2011-02-16 17:06           ` Ian Campbell
2011-02-09 11:10 ` [PATCH 2/2] xen: events: propagate irq allocation failure instead of panicing Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110216165505.GB3904@dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc='@dumpdata.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=jeremy@goop.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.