From: Greg KH <greg@kroah.com>
To: David Miller <davem@davemloft.net>
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org,
fubar@us.ibm.com, stable@kernel.org,
bonding-devel@lists.sourceforge.net
Subject: Re: [PATCH] bonding/vlan: Avoid mangled NAs on slaves without VLAN tag insertion
Date: Wed, 16 Feb 2011 13:58:55 -0800 [thread overview]
Message-ID: <20110216215855.GL5027@kroah.com> (raw)
In-Reply-To: <20110207.131754.59684095.davem@davemloft.net>
On Mon, Feb 07, 2011 at 01:17:54PM -0800, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Mon, 07 Feb 2011 19:20:55 +0000
>
> > This is related to commit f88a4a9b65a6f3422b81be995535d0e69df11bb8
> > upstream, but the bug cannot be properly fixed without the other
> > changes to VLAN tagging in 2.6.37.
> >
> > bond_na_send() attempts to insert a VLAN tag in between building and
> > sending packets of the respective formats. If the slave does not
> > implement hardware VLAN tag insertion then vlan_put_tag() will mangle
> > the network-layer header because the Ethernet header is not present at
> > this point (unlike in bond_arp_send()).
> >
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
>
> Acked-by: David S. Miller <davem@davemloft.net>
Great, thanks for the patch, now queued up for the next .32-stable
release.
greg k-h
prev parent reply other threads:[~2011-02-16 21:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 19:20 [PATCH] bonding/vlan: Avoid mangled NAs on slaves without VLAN tag insertion Ben Hutchings
2011-02-07 21:17 ` David Miller
2011-02-16 21:58 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110216215855.GL5027@kroah.com \
--to=greg@kroah.com \
--cc=bhutchings@solarflare.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.