All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 1/2] e2fsprogs: turn off enforced fsck intervals by default
Date: Wed, 16 Feb 2011 17:55:16 -0500	[thread overview]
Message-ID: <20110216225516.GE26780@thunk.org> (raw)
In-Reply-To: <4D5C1409.1030203@redhat.com>

On Wed, Feb 16, 2011 at 12:14:33PM -0600, Eric Sandeen wrote:
> The forced fsck often comes at unexpected and inopportune moments,
> and even enterprise customers are often caught by surprise when 
> this happens.  Because a filesystem with an error condition will 
> be marked as requiring fsck anyway, I submit that the time-based 
> and mount-based checks are not particularly useful, and that 
> administrators can schedule fscks on their own time, or tune2fs 
> the enforced intervals if they so choose.  Patch #1 disables the 
> intervals by default, and I've added a new mkfs option (-C) to 
> turn on the old behavior of random, unexpected, time-consuming
> fscks at boot time.  ;)
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

How about just making it be an /etc/mke2fs.conf profile.  Just use
something like this:

    get_bool_from_profile(fs_types, "enable_periodic_fsck", 0)

... and I don't think we need to have a new command-line option.
People who want old behaviour can do

[defaults]
    enable_period_fsck = true

						- Ted

  parent reply	other threads:[~2011-02-16 22:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-16 18:12 [PATCH 0/2] e2fsprogs: update mkfs defaults Eric Sandeen
2011-02-16 18:14 ` [PATCH 1/2] e2fsprogs: turn off enforced fsck intervals by default Eric Sandeen
2011-02-16 18:24   ` Lukas Czerner
2011-02-16 19:12     ` Amir Goldstein
2011-02-16 22:55   ` Ted Ts'o [this message]
2011-02-17 21:55   ` [PATCH 1/2 V2] " Eric Sandeen
2011-02-16 18:21 ` [PATCH 2/2] e2fsprogs: enable user namespace xattrs " Eric Sandeen
2011-02-16 19:15   ` Andreas Dilger
2011-02-16 19:27     ` Eric Sandeen
2011-02-16 21:49       ` Ted Ts'o
2011-02-16 21:53         ` Eric Sandeen
2011-02-16 22:56           ` Ted Ts'o
2011-02-16 22:58             ` Eric Sandeen
2011-02-16 23:01               ` Ted Ts'o
2011-02-17 21:56   ` [PATCH 2/2 V2] " Eric Sandeen
2011-02-20 23:31     ` Ted Ts'o
2011-02-21 17:00       ` Eric Sandeen
2011-02-16 22:12 ` [PATCH 0/2] e2fsprogs: update mkfs defaults Andreas Dilger
2011-02-16 22:37   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110216225516.GE26780@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.