From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur.tabi@gmail.com>
Cc: alsa-devel@alsa-project.org, s.hauer@pengutronix.de,
zengzm.kernel@gmail.com, zhaoming.zeng@freescale.com,
linuxzsc@gmail.com, arnaud.patard@rtp-net.org,
lrg@slimlogic.co.uk
Subject: Re: [PATCH v3] ASoC: Add Freescale SGTL5000 codec support
Date: Wed, 16 Feb 2011 15:01:18 -0800 [thread overview]
Message-ID: <20110216230117.GA6551@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <AANLkTi=xvpWqnChvyJvDVjCK8dH3rfd75e0c43x8a1JP@mail.gmail.com>
On Wed, Feb 16, 2011 at 04:20:37PM -0600, Timur Tabi wrote:
> > +static int sgtl5000_suspend(struct snd_soc_codec *codec, pm_message_t state)
> > +{
> > + sgtl5000_set_bias_level(codec, SND_SOC_BIAS_OFF);
> > +
> > + return 0;
> > +}
> #ifdef CONFIG_PM ?
Should be CONFIG_SUSPEND.
> > + memcpy((void *)(&sgtl5000_regs[0] + (SGTL5000_DAP_REG_OFFSET >> 1)),
> > + sgtl5000_dap_regs,
> > + 0x3a);
> I don't think you need the "(void *)"
You never need to cast to void in C. C++ requires this but not C.
next prev parent reply other threads:[~2011-02-16 23:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 22:56 [PATCH v3] ASoC: Add Freescale SGTL5000 codec support zhaoming.zeng
2011-02-16 18:01 ` Arnaud Patard
2011-02-16 18:01 ` Zeng Zhaoming
2011-02-17 2:11 ` Mark Brown
2011-02-16 19:53 ` Mark Brown
2011-02-16 18:53 ` Zeng Zhaoming
2011-02-17 6:11 ` Mark Brown
2011-02-16 22:20 ` Timur Tabi
2011-02-16 18:33 ` Zeng Zhaoming
2011-02-16 23:01 ` Mark Brown [this message]
2011-02-17 8:52 ` Arnaud Patard
2011-02-17 1:21 ` Zeng Zhaoming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110216230117.GA6551@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.patard@rtp-net.org \
--cc=linuxzsc@gmail.com \
--cc=lrg@slimlogic.co.uk \
--cc=s.hauer@pengutronix.de \
--cc=timur.tabi@gmail.com \
--cc=zengzm.kernel@gmail.com \
--cc=zhaoming.zeng@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.