All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jan Beulich <JBeulich@novell.com>
Cc: tglx@linutronix.de, hpa@zytor.com, tony.luck@intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] x86-64: use relative 32-bit pointers in exception tables
Date: Thu, 17 Feb 2011 18:25:59 +0100	[thread overview]
Message-ID: <20110217172559.GD17058@elte.hu> (raw)
In-Reply-To: <4D5D62EE02000078000327E7@vpn.id2.novell.com>


Nice patch. I've got a really small code readability nitpick:

> +#ifndef ex_insn /* until all architectures have this accessor */
> +#define ex_insn(x) (x)->insn
> +#endif

> +#else
> +#define swap_ex NULL
> +#endif

In the x86 architecture we tend to write this as:

> +#else
> +# define swap_ex NULL
> +#endif

So that the conditional structure stands out more, visually. (There might be more 
such cases in these patches as well.)

Thanks,

	Ingo

  reply	other threads:[~2011-02-17 17:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-17 17:03 [PATCH 2/3] x86-64: use relative 32-bit pointers in exception tables Jan Beulich
2011-02-17 17:25 ` Ingo Molnar [this message]
2011-02-18  8:07   ` Jan Beulich
2011-02-18  8:14     ` Ingo Molnar
2011-02-18  4:49 ` H. Peter Anvin
2011-02-18  9:34   ` Jan Beulich
2011-02-18 10:32   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110217172559.GD17058@elte.hu \
    --to=mingo@elte.hu \
    --cc=JBeulich@novell.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.