From: Greg KH <gregkh@suse.de>
To: J Freyensee <james_p_freyensee@linux.intel.com>
Cc: Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org, suhail.ahmed@intel.com
Subject: Re: [PATCH 04/12] PTI Kconfig change in misc.
Date: Thu, 17 Feb 2011 11:45:12 -0800 [thread overview]
Message-ID: <20110217194512.GA31725@suse.de> (raw)
In-Reply-To: <1297971351.3038.22.camel@localhost>
On Thu, Feb 17, 2011 at 11:35:51AM -0800, J Freyensee wrote:
> On Thu, 2011-02-17 at 11:20 -0800, Greg KH wrote:
> > On Tue, Feb 08, 2011 at 11:34:49AM -0800, james_p_freyensee@linux.intel.com wrote:
> > > From: J Freyensee <james_p_freyensee@linux.intel.com>
> > >
> > > This adds the Intel PTI Kconfig option.
> > >
> > > Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>
> > > ---
> > > drivers/misc/Kconfig | 12 ++++++++++++
> > > 1 files changed, 12 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > > index 4d073f1..f8076f1 100644
> > > --- a/drivers/misc/Kconfig
> > > +++ b/drivers/misc/Kconfig
> > > @@ -136,6 +136,18 @@ config PHANTOM
> > > If you choose to build module, its name will be phantom. If unsure,
> > > say N here.
> > >
> > > +config INTEL_MID_PTI
> >
> > Don't add new Kconfig options when there is no code for it yet to use
> > it. Merge this with the Makefile patch.
> >
>
> I do not quite understand the problem. The code for this Kconfig is
> ~/drivers/misc/pti.c and it was patch 3/12. I tested that in 'make
> menuconfig' the kernel turns the compile option on and off fine.
>
> What needs to be fixed here?
Merge it with your Makefile patch, it doesn't need to be separate.
thanks,
greg k-h
next prev parent reply other threads:[~2011-02-17 19:45 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 19:34 Resend: Request for review and addition of PTI implementation into kernel james_p_freyensee
2011-02-08 19:34 ` [PATCH 01/12] export kernel call get_task_comm() james_p_freyensee
2011-02-08 19:34 ` [PATCH 02/12] Kernel documentation for the PTI feature james_p_freyensee
2011-02-08 19:34 ` [PATCH 03/12] Intel PTI implementaiton of 1149 james_p_freyensee
2011-02-08 19:34 ` [PATCH 04/12] PTI Kconfig change in misc james_p_freyensee
2011-02-08 19:34 ` [PATCH 05/12] PTI misc Makefile addition james_p_freyensee
2011-02-08 19:34 ` [PATCH 06/12] PTI header file james_p_freyensee
2011-02-08 19:34 ` [PATCH 07/12] n_tracerouter and n_tracesink additions james_p_freyensee
2011-02-08 19:34 ` [PATCH 08/12] n_tracesink ldisc addition james_p_freyensee
2011-02-08 19:34 ` [PATCH 09/12] n_tracesink header file james_p_freyensee
2011-02-08 19:34 ` [PATCH 10/12] n_tracerouter ldisc driver james_p_freyensee
2011-02-08 19:34 ` [PATCH 11/12] n_tracerouter and n_tracesink Kconfig james_p_freyensee
2011-02-08 19:34 ` [PATCH 12/12] n_tracerouter and n_tracesink Makefile addition james_p_freyensee
2011-02-08 21:03 ` [PATCH 11/12] n_tracerouter and n_tracesink Kconfig Randy Dunlap
2011-02-17 19:23 ` [PATCH 09/12] n_tracesink header file Greg KH
2011-02-17 19:45 ` J Freyensee
2011-02-17 19:54 ` Greg KH
2011-02-17 20:10 ` J Freyensee
2011-02-17 21:43 ` Greg KH
2011-02-22 20:22 ` J Freyensee
2011-02-22 20:26 ` Greg KH
2011-02-22 22:55 ` J Freyensee
2011-02-17 19:21 ` [PATCH 07/12] n_tracerouter and n_tracesink additions Greg KH
2011-02-17 19:43 ` J Freyensee
2011-02-17 19:54 ` Greg KH
2011-02-17 20:11 ` J Freyensee
2011-02-24 11:52 ` Alan Cox
2011-02-17 19:20 ` [PATCH 06/12] PTI header file Greg KH
2011-02-17 19:41 ` J Freyensee
2011-02-17 19:55 ` Greg KH
2011-02-17 20:13 ` J Freyensee
2011-02-17 19:20 ` [PATCH 04/12] PTI Kconfig change in misc Greg KH
2011-02-17 19:35 ` J Freyensee
2011-02-17 19:45 ` Greg KH [this message]
2011-02-08 20:55 ` [PATCH 02/12] Kernel documentation for the PTI feature Randy Dunlap
2011-02-08 19:38 ` [PATCH 01/12] export kernel call get_task_comm() Christoph Hellwig
2011-02-08 19:44 ` james_p_freyensee
2011-02-08 20:04 ` Christoph Hellwig
2011-02-08 20:35 ` james_p_freyensee
2011-02-08 20:28 ` Alan Cox
2011-02-08 20:28 ` Christoph Hellwig
2011-02-08 20:36 ` Alan Cox
2011-02-15 10:57 ` Christoph Hellwig
2011-02-22 18:38 ` J Freyensee
2011-02-22 18:41 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2011-02-09 0:17 [PATCH 02/12] Kernel documentation for the PTI feature james_p_freyensee
2011-02-09 0:17 ` [PATCH 03/12] Intel PTI implementaiton of 1149 james_p_freyensee
2011-02-09 0:17 ` [PATCH 04/12] PTI Kconfig change in misc james_p_freyensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217194512.GA31725@suse.de \
--to=gregkh@suse.de \
--cc=greg@kroah.com \
--cc=james_p_freyensee@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suhail.ahmed@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.