From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: mirq-linux@rere.qmqm.pl, netdev@vger.kernel.org
Subject: Re: [PATCH v6 0/9] net: Unified offload configuration
Date: Fri, 18 Feb 2011 12:06:17 -0800 (PST) [thread overview]
Message-ID: <20110218.120617.71104636.davem@davemloft.net> (raw)
In-Reply-To: <1298039371.2211.9.camel@localhost>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 18 Feb 2011 14:29:31 +0000
> On Fri, 2011-02-18 at 15:22 +0100, Michał Mirosław wrote:
>> On Thu, Feb 17, 2011 at 02:56:11PM -0800, David Miller wrote:
> [...]
>> > Please get rid of that annoying message spit out by netif_features_change(),
>> > it's just spam. If we want notifications for stuff like this, use a
>> > non-unicast netlink message so those who want to hear it can do so.
>>
>> You mean netdev_update_features() "Features changed" message? Is it ok
>> to just demote it to DEBUG level or you want to remove it altogether?
>> What about netdev_fix_features() messages?
>
> I think you need to emit these messages at 'error' severity when fixing
> up features for a newly-added device, but at 'debug' later on.
I get one several minutes after every boot for a completely
unregistered device for some reason:
[119704.730965] (unregistered net_device): Features changed: 0x00011065 -> 0x00015065
next prev parent reply other threads:[~2011-02-18 20:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 2:59 [PATCH v6 0/9] net: Unified offload configuration Michał Mirosław
2011-02-16 2:59 ` [PATCH v6 1/9] ethtool: move EXPORT_SYMBOL(ethtool_op_set_tx_csum) to correct place Michał Mirosław
2011-02-16 2:59 ` [PATCH v6 2/9] ethtool: enable GSO and GRO by default Michał Mirosław
2011-02-16 2:59 ` [PATCH v6 3/9] ethtool: factorize ethtool_get_strings() and ethtool_get_sset_count() Michał Mirosław
2011-02-16 2:59 ` [PATCH v6 5/9] net: Introduce new feature setting ops Michał Mirosław
2011-02-16 2:59 ` [PATCH v6 4/9] ethtool: factorize get/set_one_feature Michał Mirosław
2011-02-16 2:59 ` [PATCH v6 6/9] net: ethtool: use ndo_fix_features for offload setting Michał Mirosław
2011-02-16 2:59 ` [PATCH v6 7/9] net: use ndo_fix_features for ethtool_ops->set_flags Michał Mirosław
2011-02-16 2:59 ` [PATCH v6 8/9] net: introduce NETIF_F_RXCSUM Michał Mirosław
2011-02-16 2:59 ` [PATCH v6 9/9] loopback: convert to hw_features Michał Mirosław
2011-02-17 22:56 ` [PATCH v6 0/9] net: Unified offload configuration David Miller
2011-02-18 14:22 ` Michał Mirosław
2011-02-18 14:29 ` Ben Hutchings
2011-02-18 19:27 ` Michał Mirosław
2011-02-18 20:06 ` David Miller [this message]
2011-02-19 12:28 ` Michał Mirosław
2011-02-19 12:46 ` [PATCH 1/1] Fix "(unregistered net_device): Features changed" message Michał Mirosław
2011-02-22 14:42 ` [PATCH] net: avoid initial "Features " Michał Mirosław
2011-02-22 14:43 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110218.120617.71104636.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.