Re: [lm-sensors] [PATCH] sensors-detect: Add detection of AMD

[Guenter Roeck <guenter.roeck@ericsson.com>]

On Fri, Feb 18, 2011 at 07:09:45AM -0500, Jean Delvare wrote:
> Hi Guenter,
> 
> On Thu, 17 Feb 2011 11:56:40 -0800, Guenter Roeck wrote:
> > Index: CHANGES
> > =================================> > --- CHANGES	(revision 5932)
> > +++ CHANGES	(working copy)
> > @@ -27,6 +27,7 @@
> >                          EMC1072, EMC1073, EMC1074, EMC1402, and EMC1424
> >                    Fixed address ranges checked for SMSC EMC1403 and EMC1404.
> >                    Fix detection of SPD EEPROM on DDR3 memory modules
> > +                  Add detection of AMD family 12h and 14h thermal sensors
> >  
> >  3.2.0 (2010-10-10)
> >    libsensors: Increase MAX_SENSORS_PER_TYPE to 24
> > Index: prog/detect/sensors-detect
> > =================================> > --- prog/detect/sensors-detect	(revision 5932)
> > +++ prog/detect/sensors-detect	(working copy)
> > @@ -2128,6 +2128,10 @@
> >  		driver => "k10temp",
> >  		detect => \&fam11h_pci_detect,
> >  	}, {
> > +		name => "AMD Family 12h and 14h thermal sensors",
> > +		driver => "k10temp",
> > +		detect => \&fam12h_14h_pci_detect,
> > +	}, {
> >  		name => "Intel digital thermal sensor",
> >  		driver => "coretemp",
> >  		detect => \&coretemp_detect,
> > @@ -6028,6 +6032,12 @@
> >  	return 9;
> >  }
> >  
> > +sub fam12h_14h_pci_detect
> > +{
> > +	return unless exists $pci_list{'1022:1703'};
> > +	return 9;
> > +}
> > +
> >  sub intel_amb_detect
> >  {
> >  	if ((exists $pci_list{'8086:25f0'}) ||	# Intel 5000
> > 
> 
> The code looks good and the ID is in line with Clemens' patch. Please
> commit and update wiki/Devices accordingly [1].
> 
> That being said, I'm a little curious about a couple things. Why
> PCI_DEVICE_ID_AMD_CNB17H_F3 and PCI device ID 0x1703 if the supported
> CPUs are family 12h and 14h (and not 17h)?
> 
I don't know. I wondered about it too, so I looked up the device ID
(http://pci-ids.ucw.cz/read/PC/1022) and confirmed that it applies
to family 12h/14h. Per commit log this is the Northbridge on the
respective CPUs.

0x1603 is for AMD CPU family 15h, as the define indicates. I have no idea
about its capabilities, nor how to find out.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors