All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Nico Becker <nico.becker@gmx.de>,
	linux-serial@vger.kernel.org, jianwei.yang@intel.com
Subject: Re: MAX3107 driver faulty
Date: Fri, 18 Feb 2011 13:54:20 +0000	[thread overview]
Message-ID: <20110218135420.68277c1e@bob.linux.org.uk> (raw)
In-Reply-To: <20110218135908.GA7305@pengutronix.de>

> > Have somebody test the driver,
> > or have although trouble with the chip?
> 
> I haven't, but I'll add the people who brought the driver to the
> kernel to CC. Maybe they can comment.

It had some testing but in a limited configuration and mostly for a
device that then got canned. Thus I can well believe the autocts/rts
isn't set right, and IntOscen may well only get set if the firmware
happens to do it etc

> > Because i am really new with the kernel hacking,
> > what are the next steps, build an patch?
> 
> Doing patches (one per issue) might be an idea. It is usually easier
> to talk about code. Reading Documentation/SubmittingPatches will
> probably make the process easier.

I would probably send it as four patches

1. A patch for the IntOscen configuration
2. A patch to fix autocts/rts
3. A patch to fix the register updates
4. A patch to add any platform specific stuff you need for your device.

Thanks

Alan

      reply	other threads:[~2011-02-18 14:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-18 13:31 MAX3107 driver faulty Nico Becker
2011-02-18 14:00 ` Wolfram Sang
2011-02-18 13:54   ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110218135420.68277c1e@bob.linux.org.uk \
    --to=alan@linux.intel.com \
    --cc=jianwei.yang@intel.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=nico.becker@gmx.de \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.