From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/lib/mm memlock.c
Date: 18 Feb 2011 14:51:04 -0000 [thread overview]
Message-ID: <20110218145104.6981.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac at sourceware.org 2011-02-18 14:51:04
Modified files:
lib/mm : memlock.c
Log message:
Memory unlock allows 1 page difference
As the kernel seems to be doing weird things during
mlock -> munlock - allow 1 page locking difference without
warning - and log just debug message for a 1 page difference.
Allocation happens outside critical section probably during
log_warn printing.
Should make tests passing for now.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/mm/memlock.c.diff?cvsroot=lvm2&r1=1.34&r2=1.35
--- LVM2/lib/mm/memlock.c 2011/02/18 14:16:12 1.34
+++ LVM2/lib/mm/memlock.c 2011/02/18 14:51:04 1.35
@@ -343,9 +343,15 @@
log_sys_error("close", _procselfmaps);
dm_free(_maps_buffer);
_maps_buffer = NULL;
- if (_mstats < unlock_mstats)
- log_error(INTERNAL_ERROR "Maps lock %ld < unlock %ld",
- (long)_mstats, (long)unlock_mstats);
+ if (_mstats < unlock_mstats) {
+ if ((_mstats + 4096) < unlock_mstats)
+ log_error(INTERNAL_ERROR
+ "Maps lock %ld < unlock %ld",
+ (long)_mstats, (long)unlock_mstats);
+ else
+ log_debug("Maps lock %ld < unlock %ld, 1 page difference!",
+ (long)_mstats, (long)unlock_mstats);
+ }
}
if (setpriority(PRIO_PROCESS, 0, _priority))
next reply other threads:[~2011-02-18 14:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 14:51 zkabelac [this message]
2011-03-04 16:56 ` LVM2/lib/mm memlock.c Milan Broz
-- strict thread matches above, loose matches on Subject: below --
2012-03-01 21:19 zkabelac
2012-02-01 10:48 zkabelac
2011-06-01 19:26 agk
2011-03-06 17:52 zkabelac
2010-10-25 13:00 zkabelac
2010-10-15 9:48 zkabelac
2010-07-08 14:47 zkabelac
2010-07-08 13:05 zkabelac
2010-04-01 14:53 zkabelac
2010-04-01 13:43 zkabelac
2010-03-30 14:41 zkabelac
2010-03-30 14:41 zkabelac
2010-03-09 12:31 agk
2010-03-09 10:25 zkabelac
2010-03-08 17:14 zkabelac
2010-03-08 15:55 zkabelac
2010-03-05 15:14 zkabelac
2009-11-18 18:22 mornfall
2008-05-28 23:12 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110218145104.6981.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.