From: Vipin Mehta <vmehta@atheros.com>
To: Joe Perches <joe@perches.com>
Cc: Greg KH <greg@kroah.com>, Vipin Mehta <Vipin.Mehta@Atheros.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH 01/15] staging: ath6kl: Fixing a NULL pointer exception
Date: Fri, 18 Feb 2011 14:40:13 -0800 [thread overview]
Message-ID: <20110218224013.GA2439@vmehta-desktop> (raw)
In-Reply-To: <1298066200.7179.12.camel@Joe-Laptop>
On Fri, Feb 18, 2011 at 01:56:40PM -0800, Joe Perches wrote:
> On Fri, 2011-02-18 at 13:29 -0800, Greg KH wrote:
> > On Fri, Feb 18, 2011 at 01:13:02PM -0800, Vipin Mehta wrote:
> > > The driver was dereferencing a NULL pointer because of the device instance
> > > being registered via the set_wiphy_dev() function. The function
> > > ar6000_avail_ev() was passing the argument as NULL instead of using the one
> > > returned by the MMC stack through the probe callback.
> > I've applied all of these, but note that some of them add whitespace
> > warnings. In the future, I'll reject those that do this, please always
> > run your patches through scripts/checkpatch.pl to not have this happen.
>
> Vipin,
>
> A good test is to generate the patches using git format-patch
> then apply them to a new, separate branch using git am.
> Whitespace problems will cause rejects.
>
> You can use git am --whitespace=fix on each patch if necessary,
> then regenerate the git format-patch set from that new branch.
>
> cheers, Joe
>
Got it. Shall do that for subsequent patches.
prev parent reply other threads:[~2011-02-18 22:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 21:13 [PATCH 01/15] staging: ath6kl: Fixing a NULL pointer exception Vipin Mehta
2011-02-18 21:13 ` [PATCH 02/15] staging: ath6kl: Fixing key settings for WPA/WPA2 Vipin Mehta
2011-02-18 21:13 ` [PATCH 03/15] staging: ath6kl: Return correct scan complete status Vipin Mehta
2011-02-18 21:13 ` [PATCH 05/15] staging: ath6kl: Fixing driver initialization for manufacturing mode Vipin Mehta
2011-02-18 21:13 ` [PATCH 07/15] staging: ath6kl: Adding support for txop bursting enable/disable Vipin Mehta
2011-02-18 21:13 ` [PATCH 08/15] staging: ath6kl: Fixing a memory leak Vipin Mehta
2011-02-18 21:13 ` [PATCH 10/15] staging: ath6kl: Add configuration for excessive TX retry threshold Vipin Mehta
2011-02-19 10:00 ` Dan Carpenter
2011-02-18 21:13 ` [PATCH 12/15] staging: ath6kl: Fixing the cached copy of the BSS filter set by user Vipin Mehta
2011-02-18 21:13 ` [PATCH 13/15] staging: ath6kl: Adding state in driver to track the sme state Vipin Mehta
2011-02-18 21:13 ` [PATCH 15/15] staging: ath6kl: Fixing disappearing of scan list due to jiffies wrap over Vipin Mehta
2011-02-18 21:29 ` [PATCH 01/15] staging: ath6kl: Fixing a NULL pointer exception Greg KH
2011-02-18 21:56 ` Joe Perches
2011-02-18 22:40 ` Vipin Mehta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110218224013.GA2439@vmehta-desktop \
--to=vmehta@atheros.com \
--cc=Vipin.Mehta@Atheros.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.