From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Mattia Dongili <malattia@linux.it>
Cc: platform-driver-x86@vger.kernel.org, thomas.klose@hiperscan.com
Subject: Re: [PATCH 3/8] sony-laptop: ignore hard switch rfkill events (SPIC)
Date: Sat, 19 Feb 2011 16:00:38 +0000 [thread overview]
Message-ID: <20110219160038.GA5751@srcf.ucam.org> (raw)
In-Reply-To: <20110219124654.GA1726@kamineko.org>
On Sat, Feb 19, 2011 at 09:46:54PM +0900, Mattia Dongili wrote:
> On Sat, Feb 19, 2011 at 03:06:18AM +0000, Matthew Garrett wrote:
> > Do you possibly want to catch these and make sure the kernel rfkill
> > state matches the hardware?
>
> hmmmm, to be honest I'm not entirely sure what the actual problem is.
> Maybe it's just a timing issue that is made better by avoiding the
> input/acpi event generation. For now drop this patch (there is a
> different workaround using the mask parameter).
Delivering it to userspace can be racy - rfkill-input will try to toggle
the state as well. So I think this is the right thing to do, but you
might also want to use it to check the current hardware state and update
the state of the rfkill device.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-02-19 16:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-19 2:52 [0/8] sony-laptop for 2.6.39 Mattia Dongili
2011-02-19 2:52 ` [PATCH 1/8] sony-laptop: add some debug printk useful for bug reports Mattia Dongili
2011-02-19 2:52 ` [PATCH 2/8] sony-laptop: documentation updates Mattia Dongili
2011-02-19 2:52 ` [PATCH 3/8] sony-laptop: ignore hard switch rfkill events (SPIC) Mattia Dongili
2011-02-19 3:06 ` Matthew Garrett
2011-02-19 12:46 ` Mattia Dongili
2011-02-19 12:52 ` Thomas Klose
2011-02-19 16:00 ` Matthew Garrett [this message]
2011-02-20 3:13 ` Mattia Dongili
2011-02-19 2:52 ` [PATCH 4/8] sony-laptop: use pr_<level> for messages Mattia Dongili
2011-02-19 2:52 ` [PATCH 5/8] sony-laptop: remove unused Type4 define Mattia Dongili
2011-02-19 2:52 ` [PATCH 6/8] sony-laptop: cache handles and report them via sysfs Mattia Dongili
2011-02-19 2:52 ` [PATCH 7/8] sony-laptop: implement keyboard backlight support Mattia Dongili
2011-02-19 2:52 ` [PATCH 8/8] sony-laptop: implement new backlight control method Mattia Dongili
2011-02-21 20:51 ` [0/8] sony-laptop for 2.6.39 Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110219160038.GA5751@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=malattia@linux.it \
--cc=platform-driver-x86@vger.kernel.org \
--cc=thomas.klose@hiperscan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.