From: Jakub Narebski <jnareb@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 2/3] gitweb/gitweb.perl: remove use of qw(...) as parentheses
Date: Sat, 19 Feb 2011 17:02:29 +0100 [thread overview]
Message-ID: <201102191702.29648.jnareb@gmail.com> (raw)
In-Reply-To: <201102191654.41601.jnareb@gmail.com>
Jakub Narebski wrote:
> On Sat, 19 Feb 2011, Ævar Arnfjörð Bjarmason wrote:
> [...]
> > --- a/gitweb/gitweb.perl
> > +++ b/gitweb/gitweb.perl
> > @@ -3501,7 +3501,7 @@ sub print_feed_meta {
> > $href_params{'-title'} = 'log';
> > }
> >
> > - foreach my $format qw(RSS Atom) {
> > + foreach my $format (qw(RSS Atom)) {
> > my $type = lc($format);
> > my %link_attr = (
> > '-rel' => 'alternate',
Ah, sorry, if Perl reqyures to use 'foreach (@array)', then
of course one should use 'forach (qw(A B))'.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2011-02-19 16:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-19 14:10 [PATCH] gitweb/gitweb.perl: remove use of qw(...) as parentheses Ævar Arnfjörð Bjarmason
2011-02-19 15:27 ` [PATCH v2 0/3] Fix failure-causing warnings in Gitweb + improve gitweb-lib.sh Ævar Arnfjörð Bjarmason
2011-02-19 15:27 ` [PATCH v2 1/3] t/gitweb-lib.sh: print to stderr when gitweb_run has errors Ævar Arnfjörð Bjarmason
2011-02-19 15:46 ` Jakub Narebski
2011-02-19 16:17 ` Ævar Arnfjörð Bjarmason
2011-02-19 18:16 ` Jakub Narebski
2011-02-19 19:11 ` Ævar Arnfjörð Bjarmason
2011-02-21 6:40 ` Junio C Hamano
2011-02-19 15:27 ` [PATCH v2 2/3] gitweb/gitweb.perl: remove use of qw(...) as parentheses Ævar Arnfjörð Bjarmason
2011-02-19 15:54 ` Jakub Narebski
2011-02-19 16:02 ` Jakub Narebski [this message]
2011-02-19 16:06 ` Ævar Arnfjörð Bjarmason
2011-02-20 14:42 ` Jakub Narebski
2011-02-19 15:27 ` [PATCH v2 3/3] gitweb/gitweb.perl: don't call S_ISREG() with undef Ævar Arnfjörð Bjarmason
2011-02-19 15:57 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102191702.29648.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.