All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serge@hallyn.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Oleg Nesterov <oleg@redhat.com>,
	serge@hallyn.com, LSM <linux-security-module@vger.kernel.org>,
	James Morris <jmorris@namei.org>,
	Kees Cook <kees.cook@canonical.com>,
	containers@lists.linux-foundation.org,
	kernel list <linux-kernel@vger.kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Michael Kerrisk <mtk.manpages@gmail.com>,
	xemul@parallels.com, dhowells@redhat.com,
	Daniel Lezcano <daniel.lezcano@free.fr>
Subject: [PATCH 4/4] userns: uts and ipc: fix checkpatch warning
Date: Mon, 21 Feb 2011 04:05:27 +0000	[thread overview]
Message-ID: <20110221040527.GD12580@mail.hallyn.com> (raw)
In-Reply-To: <20110221040156.GA12580@mail.hallyn.com>

As pointed out by Andrew Morton (and checkpatch), init/version.c
(and ipc/msgutil.c) should not have an extern declaration for
init_user_ns.  Instead, move those to ipc_namespace.h and utsname.h.

Signed-off-by: Serge E. Hallyn <serge.hallyn@canonical.com>
---
 include/linux/ipc_namespace.h |    3 ++-
 include/linux/utsname.h       |    1 +
 init/version.c                |    1 -
 ipc/msgutil.c                 |    2 --
 4 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/include/linux/ipc_namespace.h b/include/linux/ipc_namespace.h
index 9974429..ebd4a93 100644
--- a/include/linux/ipc_namespace.h
+++ b/include/linux/ipc_namespace.h
@@ -15,6 +15,8 @@
 
 #define IPCNS_CALLBACK_PRI 0
 
+struct user_namespace;
+extern struct user_namespace init_user_ns;
 
 struct ipc_ids {
 	int in_use;
@@ -24,7 +26,6 @@ struct ipc_ids {
 	struct idr ipcs_idr;
 };
 
-struct user_namespace;
 struct ipc_namespace {
 	atomic_t	count;
 	struct ipc_ids	ids[3];
diff --git a/include/linux/utsname.h b/include/linux/utsname.h
index 165b17b..69957ca 100644
--- a/include/linux/utsname.h
+++ b/include/linux/utsname.h
@@ -38,6 +38,7 @@ struct new_utsname {
 #include <linux/err.h>
 
 struct user_namespace;
+extern struct user_namespace init_user_ns;
 
 struct uts_namespace {
 	struct kref kref;
diff --git a/init/version.c b/init/version.c
index 97bb86f..86fe0cc 100644
--- a/init/version.c
+++ b/init/version.c
@@ -21,7 +21,6 @@ extern int version_string(LINUX_VERSION_CODE);
 int version_string(LINUX_VERSION_CODE);
 #endif
 
-extern struct user_namespace init_user_ns;
 struct uts_namespace init_uts_ns = {
 	.kref = {
 		.refcount	= ATOMIC_INIT(2),
diff --git a/ipc/msgutil.c b/ipc/msgutil.c
index d91ff4b..8b5ce5d 100644
--- a/ipc/msgutil.c
+++ b/ipc/msgutil.c
@@ -20,8 +20,6 @@
 
 DEFINE_SPINLOCK(mq_lock);
 
-extern struct user_namespace init_user_ns;
-
 /*
  * The next 2 defines are here bc this is the only file
  * compiled when either CONFIG_SYSVIPC and CONFIG_POSIX_MQUEUE
-- 
1.7.0.4


  parent reply	other threads:[~2011-02-21  4:05 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-21  4:01 [PATCH 1/4] userns: let clone_uts_ns() handle setting uts->user_ns Serge E. Hallyn
2011-02-21  4:02 ` [PATCH 2/4] userns: let copy_ipcs handle setting ipc_ns->user_ns Serge E. Hallyn
     [not found]   ` <20110221040230.GB12580-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2011-02-21 10:05     ` Daniel Lezcano
2011-02-24  0:22     ` Serge E. Hallyn
2011-02-21 10:05   ` Daniel Lezcano
2011-02-24  0:22   ` Serge E. Hallyn
2011-02-24  9:55     ` Daniel Lezcano
     [not found]     ` <20110224002204.GB27640-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2011-02-24  9:55       ` Daniel Lezcano
2011-02-21  4:02 ` [PATCH 3/4] Add the required user_ns parameter to security_capable Serge E. Hallyn
     [not found] ` <20110221040156.GA12580-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2011-02-21  4:02   ` [PATCH 2/4] userns: let copy_ipcs handle setting ipc_ns->user_ns Serge E. Hallyn
2011-02-21  4:02   ` [PATCH 3/4] Add the required user_ns parameter to security_capable Serge E. Hallyn
2011-02-21  4:05   ` [PATCH 4/4] userns: uts and ipc: fix checkpatch warning Serge E. Hallyn
2011-02-21 10:03   ` [PATCH 1/4] userns: let clone_uts_ns() handle setting uts->user_ns Daniel Lezcano
2011-02-24  0:21   ` Serge E. Hallyn
2011-02-24  0:22   ` [PATCH 5/4] Clean up capability.h and capability.c Serge E. Hallyn
2011-02-21  4:05 ` Serge E. Hallyn [this message]
2011-02-21 10:03 ` [PATCH 1/4] userns: let clone_uts_ns() handle setting uts->user_ns Daniel Lezcano
     [not found]   ` <4D623886.3010505-GANU6spQydw@public.gmane.org>
2011-02-21 13:41     ` Oleg Nesterov
2011-02-21 13:41   ` Oleg Nesterov
2011-02-21 13:58     ` Serge E. Hallyn
     [not found]       ` <20110221135803.GA15871-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2011-02-21 14:23         ` Daniel Lezcano
2011-02-21 14:23       ` Daniel Lezcano
     [not found]     ` <20110221134129.GA15563-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-02-21 13:58       ` Serge E. Hallyn
2011-02-24  0:21 ` Serge E. Hallyn
     [not found]   ` <20110224002141.GA27640-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2011-02-24  9:54     ` Daniel Lezcano
2011-02-24  9:54   ` Daniel Lezcano
2011-02-24  0:22 ` [PATCH 5/4] Clean up capability.h and capability.c Serge E. Hallyn
     [not found]   ` <20110224002249.GA28659-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2011-02-24  9:56     ` Daniel Lezcano
2011-02-24  9:56   ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110221040527.GD12580@mail.hallyn.com \
    --to=serge@hallyn.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=daniel.lezcano@free.fr \
    --cc=dhowells@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=jmorris@namei.org \
    --cc=kees.cook@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=oleg@redhat.com \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.