From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] staging: ath6kl: cleanup in SEND_FRAME ioctl
Date: Mon, 21 Feb 2011 05:02:17 +0000 [thread overview]
Message-ID: <20110221050217.GA29843@kroah.com> (raw)
In-Reply-To: <20110220124832.GA1898@bicker>
On Sun, Feb 20, 2011 at 08:45:44PM -0800, Luis R. Rodriguez wrote:
> On Sun, Feb 20, 2011 at 8:14 PM, Greg KH <greg@kroah.com> wrote:
> > On Sun, Feb 20, 2011 at 08:00:38PM -0800, Luis R. Rodriguez wrote:
> >> On Sun, Feb 20, 2011 at 7:18 AM, Vipin Mehta <vmehta@atheros.com> wrote:
> >> > On Sun, Feb 20, 2011 at 04:49:08AM -0800, Dan Carpenter wrote:
> >> >> The original code was written in a funny way where every statement was
> >> >> part of else if blocks. I broke them up into separate statements by
> >> >> adding breaks on failure conditions.
> >> >>
> >> >> Signed-off-by: Dan Carpenter <error27@gmail.com>
> >>
> >> Can you guys please join IRC? ...
> >
> > That is not a requirement for kernel development, sorry.
>
> No, but I'm not asking you, I'm asking Vipin and other developers,
> using IRC is a good idea for internal coordination.
I agree, but that wasn't what you said here :)
> I see no way Vipin checking with Joe if he had his first set of
> patches ready. We need to do major cleanup on the driver *now* and
> these sort of miscommunication is just irritating. How do you
> recommend we coordinate cleanup with random patches being ACKed in the
> process without proper coordination?
You get Joe and Vipin to work together and agree with what to do. You
don't email 4 other people and 2 mailing lists with a request to join
IRC :)
It's not like we don't do this kind of things all the time, and have
been for years, it just takes a willingness for the people involved to
work together. Hopefully that is the case here.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-02-21 5:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-20 12:49 [patch 1/2] staging: ath6kl: cleanup in SEND_FRAME ioctl Dan Carpenter
2011-02-20 15:18 ` Vipin Mehta
2011-02-21 4:00 ` Luis R. Rodriguez
2011-02-21 4:14 ` Greg KH
2011-02-21 4:45 ` Luis R. Rodriguez
2011-02-21 5:02 ` Greg KH [this message]
2011-02-21 5:04 ` Luis R. Rodriguez
2011-02-22 16:42 ` Joe Perches
2011-02-22 17:36 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221050217.GA29843@kroah.com \
--to=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.