From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/3] Staging: xgifb: Removes dead code and unused
Date: Mon, 21 Feb 2011 09:43:29 +0000 [thread overview]
Message-ID: <20110221094329.GG1898@bicker> (raw)
In-Reply-To: <1298279347-8825-1-git-send-email-martinez.javier@gmail.com>
On Mon, Feb 21, 2011 at 10:09:04AM +0100, Javier Martinez Canillas wrote:
> [PATCH 1/3] Staging: xgifb: Removes dead code
> [PATCH 2/3] Staging: xgifb: Remove unused functions
> [PATCH 3/3] Staging: xgifb: Remove unused spinlock conditional compilation logic
Acked-by: Dan Carpenter <error27@gmail.com>
Looks good. If you wanted to send some follow on patches, there are
some related things you could delete as well.
1) All references to XGIfb_accel in drivers/staging/xgifb/XGI_accel.h
and drivers/staging/xgifb/XGI_main_26.c
2) spinlock_t lockaccel; from the video_info struct in
drivers/staging/xgifb/XGIfb.h
3) The fbcon_XGI_sync() function doesn't do anything. You can delete
all references to it. Leave the ->fb_sync function pointer NULL.
regards,
dan carpenter
prev parent reply other threads:[~2011-02-21 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 9:09 [PATCH 0/3] Staging: xgifb: Removes dead code and unused spinlock conditional compilation logic Javier Martinez Canillas
2011-02-21 9:43 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221094329.GG1898@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.