From: Felipe Balbi <balbi@ti.com>
To: David Cohen <dacohen@gmail.com>
Cc: balbi@ti.com, Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org, mingo@elte.hu,
peterz@infradead.org, linux-omap@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h
Date: Mon, 21 Feb 2011 16:08:11 +0200 [thread overview]
Message-ID: <20110221140811.GH23087@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <AANLkTin6SY6oUd8j3dcvjoTrPn4P2XP=hX5S+D8s1J+g@mail.gmail.com>
Hi,
On Mon, Feb 21, 2011 at 04:05:14PM +0200, David Cohen wrote:
> On Mon, Feb 21, 2011 at 3:57 PM, Felipe Balbi <balbi@ti.com> wrote:
> > Hi,
> >
> > On Mon, Feb 21, 2011 at 03:51:25PM +0200, Alexey Dobriyan wrote:
> >> > I rather have the split done and kill the circular dependency.
> >>
> >> It's not circular for starters.
> >
> > how come ? wait.h depends on sched and sched.h depends on wait.h
>
> The tricky thing is wait.h doesn't depend on sched.h, but the file
> which uses wake_up*() macro defined on wait.h will depend on sched.h
> (what is still bad). wait.h should provide all dependencies to use a
That's why I say wait.h depends on sched.h because it uses a macro
defined in sched.h
--
balbi
prev parent reply other threads:[~2011-02-21 14:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 10:20 [PATCH 0/1] Fix linux/wait.h header file David Cohen
2011-02-21 10:20 ` [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h David Cohen
2011-02-21 11:05 ` Alexey Dobriyan
2011-02-21 12:11 ` David Cohen
2011-02-21 12:30 ` Felipe Balbi
2011-02-21 13:51 ` Alexey Dobriyan
2011-02-21 13:57 ` Felipe Balbi
2011-02-21 14:05 ` David Cohen
2011-02-21 14:08 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221140811.GH23087@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=adobriyan@gmail.com \
--cc=dacohen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.