From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [libvirt] [PATCH] libxenlight driver Date: Mon, 21 Feb 2011 17:15:03 +0000 Message-ID: <20110221171503.GK3172@redhat.com> References: <4D5DCB44.3060909@novell.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <4D5DCB44.3060909@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jim Fehlig Cc: LibVir , xen-devel , Markus Gross List-Id: xen-devel@lists.xenproject.org On Thu, Feb 17, 2011 at 06:28:36PM -0700, Jim Fehlig wrote: > Here's the latest version of a libxenlight driver for libvirt. > > I've added a per-domain libxl_ctx in addition to the driver wide > context. The former is stored in virDomainObject privateData and used > for operations on the domain. The latter is stored in driver private > data and is used for non-domain related libxl calls, e.g. getVersion, > getNodeInfo, etc. This approach was suggested by Ian Jackson and > Stefano Stabellini and appears to be working much better than a single, > driver wide libxl_ctx. I no longer have the restart issues described in > the first patch posting [1]. > > Your review and comments are much appreciated! I've not had a chance todo a proper review yet, but after skimming the patch I think your impl / architecture looks pretty good. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|