From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur.tabi@gmail.com>
Cc: alsa-devel@alsa-project.org, s.hauer@pengutronix.de,
zengzm.kernel@gmail.com, zhaoming.zeng@freescale.com,
linuxzsc@gmail.com, arnaud.patard@rtp-net.org,
lrg@slimlogic.co.uk
Subject: Re: [PATCH v4] ASoC: Add Freescale SGTL5000 codec support
Date: Mon, 21 Feb 2011 18:47:33 +0000 [thread overview]
Message-ID: <20110221184732.GC5192@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <AANLkTinVCB5RdcB9Um+d5La9-_0x6zKmH-9V5He+wJ+z@mail.gmail.com>
On Mon, Feb 21, 2011 at 08:59:58AM -0600, Timur Tabi wrote:
> On Sun, Feb 20, 2011 at 6:09 PM, <zhaoming.zeng@freescale.com> wrote:
>
> > +#Freescale SGTL5000 codec
> > +config SND_SOC_SGTL5000
> > + tristate
> > +
> I meant that you should add actual "help" text so that a person
> selecting this driver would know what it is. Like this:
> config SND_SOC_SGTL5000
> tristate "Freescale SGTL5000 audio codec"
> help
> Select this option to enable the Freescale SGTL5000 audio codec, etc etc
Not for mosts CODEC drivers, these should be selected by the machine
drivers which use them rather than enabled directly by users so they are
not expected to have help text, except in the unusual case that they're
set up for use with OpenFirmware without bindings.
next prev parent reply other threads:[~2011-02-21 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 0:09 [PATCH v4] ASoC: Add Freescale SGTL5000 codec support zhaoming.zeng
2011-02-21 14:59 ` Timur Tabi
2011-02-21 18:47 ` Mark Brown [this message]
2011-02-21 19:38 ` Timur Tabi
2011-02-22 13:43 ` Sascha Hauer
2011-02-23 0:00 ` Zeng Zhaoming
2011-02-23 7:47 ` Arnaud Patard
2011-02-23 0:19 ` Zeng Zhaoming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221184732.GC5192@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.patard@rtp-net.org \
--cc=linuxzsc@gmail.com \
--cc=lrg@slimlogic.co.uk \
--cc=s.hauer@pengutronix.de \
--cc=timur.tabi@gmail.com \
--cc=zengzm.kernel@gmail.com \
--cc=zhaoming.zeng@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.