From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Anand Gadiyar <gadiyar@ti.com>
Cc: linux-bluetooth@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: [PATCH -next] bluetooth: fix build break
Date: Tue, 22 Feb 2011 09:14:22 -0300 [thread overview]
Message-ID: <20110222121422.GA2249@joana> (raw)
In-Reply-To: <1298358789-13202-1-git-send-email-gadiyar@ti.com>
Hi Anand,
* Anand Gadiyar <gadiyar@ti.com> [2011-02-22 12:43:09 +0530]:
> Linux-next as of 20110217 complains when building for OMAP1.
>
> LD vmlinux
> `hci_sock_cleanup' referenced in section `.init.text' of net/built-in.o: defined in discarded section `.exit.text' of net/built-in.o
> `hci_sock_cleanup' referenced in section `.init.text' of net/built-in.o: defined in discarded section `.exit.text' of net/built-in.o
> make: *** [vmlinux] Error 1
>
> A recent patch by Gustavo (Bluetooth: Merge L2CAP and SCO modules
> into bluetooth.ko) introduced this by calling the hci_sock_cleanup
> function in the error path of bt_init.
>
> Fix this by dropping the __exit marking for hci_sock_cleanup.
>
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> Cc: Gustavo F. Padovan <padovan@profusion.mobi>
> ---
> net/bluetooth/hci_sock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I didn't catch on my system, applied. Thanks for fixing this.
--
Gustavo F. Padovan
http://profusion.mobi
prev parent reply other threads:[~2011-02-22 12:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 7:13 [PATCH -next] bluetooth: fix build break Anand Gadiyar
2011-02-22 7:13 ` Anand Gadiyar
2011-02-22 12:14 ` Gustavo F. Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222121422.GA2249@joana \
--to=padovan@profusion.mobi \
--cc=gadiyar@ti.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.